Skip to content

fix(api-reference): add a code snippet for Astro.params with SSR#9702

Merged
sarah11918 merged 3 commits into
withastro:mainfrom
ArmandPhilippot:fix/api-reference-astro-params
Oct 16, 2024
Merged

fix(api-reference): add a code snippet for Astro.params with SSR#9702
sarah11918 merged 3 commits into
withastro:mainfrom
ArmandPhilippot:fix/api-reference-astro-params

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

Description (required)

Based on a discussion in #9673, I updated the Astro.params section with the following changes:

  • Move the code snippet under In SSR builds, to In Static builds
  • Add a new code snippet under In SSR builds to show an example specific to SSR

Related issues & labels (optional)

  • Suggested label: code snippet update

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 16, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 511c966
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/670fd65753f679000890c164
😎 Deploy Preview https://deploy-preview-9702--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment thread src/content/docs/en/reference/api-reference.mdx Outdated
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Oct 16, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/api-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love this change @ArmandPhilippot

@sarah11918 sarah11918 merged commit d377f09 into withastro:main Oct 16, 2024
@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) code snippet update Updates a code sample: typo, outdated code etc. labels Oct 16, 2024
@ArmandPhilippot ArmandPhilippot deleted the fix/api-reference-astro-params branch October 16, 2024 15:10
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Oct 17, 2024
yanthomasdev added a commit that referenced this pull request Oct 17, 2024
See #9702

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc. improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants