Skip to content

clarify layout styling section of blog tutorial closes #9689#9882

Merged
sarah11918 merged 5 commits into
withastro:mainfrom
Dillonpw:main
Oct 30, 2024
Merged

clarify layout styling section of blog tutorial closes #9689#9882
sarah11918 merged 5 commits into
withastro:mainfrom
Dillonpw:main

Conversation

@Dillonpw
Copy link
Copy Markdown
Contributor

@Dillonpw Dillonpw commented Oct 30, 2024

Description (required)

Clarification to the blog tutorial, where layouts are introduced and how the implementation of layouts will effect existing styles as discussed in issue #9689

Related issues & labels (optional)

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 30, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eff7c7e
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67224a7ac160770008645fa7
😎 Deploy Preview https://deploy-preview-9882--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Oct 30, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en tutorial/4-layouts/1.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 reviewed Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for picking this up and running with it @Dillonpw ! 🙌

I just formatted it in our Starlight "note" syntax. And, on the original issue, that note was meant to replace needing to say anything in the paragraph above the list, so I just went ahead and removed that while I was there! As soon as I can verify the preview looks fine with this formatting of a note inside a box (:sweat_smile: ), it'll be good to go! :rocket:

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) tutorial Content/UI for the Build a Blog Tutorial labels Oct 30, 2024
sarah11918
sarah11918 reviewed Oct 30, 2024
View reviewed changes
Comment thread src/content/docs/en/tutorial/4-layouts/1.mdx Outdated
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Oct 30, 2024
@sarah11918 sarah11918 merged commit 9a27db6 into withastro:main Oct 30, 2024
@jsparkdev jsparkdev mentioned this pull request Oct 31, 2024
Merged
@Nin3lee Nin3lee mentioned this pull request Oct 31, 2024
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Oct 31, 2024
@ArmandPhilippot
i18n(fr): update tutorial/4-layouts/1.mdx
aa85df7 
See withastro#9882
@ArmandPhilippot ArmandPhilippot mentioned this pull request Oct 31, 2024
Merged
yanthomasdev added a commit that referenced this pull request Oct 31, 2024
@ArmandPhilippot @yanthomasdev @dreyfus92
i18n(fr): update tutorial/4-layouts/1.mdx (#9897)
e4988da 
See #9882

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: dreyfus92 <85648028+dreyfus92@users.noreply.github.com>
@morinokami morinokami mentioned this pull request Jan 24, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

Assignees

No one assigned

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! tutorial Content/UI for the Build a Blog Tutorial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Dillonpw @astrobot-houston @sarah11918