Add discourse to social icons#1909
Conversation
🦋 Changeset detectedLatest commit: 119d5c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
delucis
left a comment
There was a problem hiding this comment.
Thank you for the contribution @joshka! Have one small suggestion.
I might also move the new discourse entry in Icons.ts up to be with the other social icons although we don’t have a strict rule about this, i.e. I guess immediately after blueSky would make sense to keep social platforms roughly grouped together.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
done in 39de623 |
delucis
left a comment
There was a problem hiding this comment.
Thank you @joshka — looks great 🙌
Will merge this when we’re ready to cut our next patch release. (Merged PRs go live in our docs immediately, so we hold off until just before release to avoid someone seeing a feature in the docs that isn’t actually available yet.)
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Description
Forum software - https://discourse.org/
The middle icon is the new icon (in the context of https://github.com/ratatui-org/ratatui-website/)
