Enforce style containment to <Steps> list items#1948
Merged
Conversation
🦋 Changeset detectedLatest commit: e132b8b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
This was referenced Jun 5, 2024
Merged
This was referenced Jun 26, 2024
Yoxnear
pushed a commit
to Yoxnear/starlight-custom
that referenced
this pull request
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request enforces style containment to the
<Steps>component list items.Even tho this change was not technically required until now, Chrome 126 having an Early Stable release date sets to Wed, Jun 5, 2024 breaks the current implementation.
Any
<Steps>component containing a nested list items (Markdown/HTML list, tabs, file tree, etc.) will have its counter broken. Here is an example from the Starlight documentation with this change:The change is probably part of Chrome re-write of CSS counters and ordered list numbering code but it's a bit difficult to figure out if the behavior is a bug or a proper implementation of the spec considering the
whatwgrepository contains many issues related to this topic, some efforts have been done to clarify the behavior but it's still a bit unclear and there seems to be some exceptions when the default counter (the one we use) is read from a::beforepseudo element.I'll open an issue in the Chromium tracker altho, even if it ends up being a bug, a fix will probably take a while to be released (Wed, Aug 14, 2024 at the earliest) so I think it's better to enforce the style containment now considering it's the behavior we want.
Note that to reproduce the issue, you need at least Chrome Beta (126 at the time of the PR).