Skip to content

Refactor <Steps> counter#2041

Merged
delucis merged 7 commits into
withastro:mainfrom
HiDeoo:hd-fix-steps-counter-attempt-2
Jun 20, 2024
Merged

Refactor <Steps> counter#2041
delucis merged 7 commits into
withastro:mainfrom
HiDeoo:hd-fix-steps-counter-attempt-2

Conversation

@HiDeoo
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo commented Jun 19, 2024 •
edited
Loading

Description

A new attempt at fixing <Steps> counter using a custom counter.

This PR is a draft as I just wanted a preview URL to share. If the approach is working and accepted, tests would need to be updated and a changeset to be added.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 19, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d3f5d4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jun 20, 2024 6:05pm

@github-actions github-actions Bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Jun 19, 2024
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 19, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/steps.mdx Source added, will be tracked.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@HiDeoo HiDeoo mentioned this pull request Jun 19, 2024
Closed
delucis
delucis reviewed Jun 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good!

Tested in Chrome 126, Safari, and Firefox on macOS without issues. Maybe worth testing on Windows if someone is able? I think we had issues with Windows on the previous fix.

Comment thread packages/starlight/user-components/rehype-steps.ts
@lorenzolewis
Copy link
Copy Markdown
Contributor

lorenzolewis commented Jun 19, 2024

Tested on Safari on iOS 17.5.1 (21F90) and LGTM!

@liruifengv
Copy link
Copy Markdown
Member

liruifengv commented Jun 20, 2024

Tested in Chrome, Edge and Firefox on Windows11, works perfect!

@delucis
Copy link
Copy Markdown
Member

delucis commented Jun 20, 2024

Thanks for testing @lorenzolewis and @liruifengv! I know @HiDeoo may have less time to work on this and I feel like the bug is relatively urgent, so will take over this PR now and polish it up for release.

@github-actions github-actions Bot removed the 📚 docs Documentation website changes label Jun 20, 2024
@delucis delucis added the 🌟 patch Change that triggers a patch release label Jun 20, 2024
@delucis delucis marked this pull request as ready for review June 20, 2024 18:03
delucis
delucis approved these changes Jun 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for figuring out this fix @HiDeoo!

@delucis delucis merged commit 8af5a60 into withastro:main Jun 20, 2024
@astrobot-houston astrobot-houston mentioned this pull request Jun 20, 2024
Merged
This was referenced Aug 12, 2024
Open
Open
@Playgirlkaybraz11 Playgirlkaybraz11 mentioned this pull request Aug 15, 2024
Open
@atogura atogura mentioned this pull request Aug 16, 2024
Open
This was referenced Aug 19, 2024
Open
Open
Open
Open
Open
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
@HiDeoo @delucis
Refactor <Steps> counter (withastro#2041)
7417e60 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<Steps> Numbers out of order

5 participants

@HiDeoo @astrobot-houston @lorenzolewis @liruifengv @delucis