Skip to content

Make sure to enable text-autospace even in Chromium-based browsers#3890

Merged
delucis merged 2 commits into
withastro:mainfrom
tats-u:autospace2
May 8, 2026
Merged

Make sure to enable text-autospace even in Chromium-based browsers#3890
delucis merged 2 commits into
withastro:mainfrom
tats-u:autospace2

Conversation

@tats-u
Copy link
Copy Markdown
Contributor

@tats-u tats-u commented May 8, 2026

Description

:lang(zh, ja) used in #3872 shamefully has not been supported Chromium and Safari. As a result, text-autospace has been enabled only in Firefox. Replaced it with the combination of :lang(zh) and :lang(ja).

Screenshot in Chrome (Pay attention to the slight presence of whitespace around "Astro" and "Starlight"):

Before (https://starlight.astro.build/ja/getting-started/):

image

After:

image

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2026

🦋 Changeset detected

Latest commit: d6d2bfc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented May 8, 2026

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit d6d2bfc
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/69fe0f199b1a040008c0f036
😎 Deploy Preview https://deploy-preview-3890--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions Bot added the 🌟 core Changes to Starlight’s main package label May 8, 2026
@tats-u
Copy link
Copy Markdown
Contributor Author

tats-u commented May 8, 2026

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! Based on the table on MDN it looks like Safari also supports the comma-separated list, but Chromium browsers do not. Easy fix though in this case luckily.

@delucis delucis added the 🌟 patch Change that triggers a patch release label May 8, 2026
@delucis delucis merged commit 2d05e18 into withastro:main May 8, 2026
17 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 8, 2026
@tats-u tats-u deleted the autospace2 branch May 9, 2026 01:58
@tats-u
Copy link
Copy Markdown
Contributor Author

tats-u commented May 9, 2026

Thank you but we forgot to fix the title of this issue and the comment.

@tats-u tats-u changed the title Make sure to enable text-autospace even in non-Firefox browsers Make sure to enable text-autospace even in Chromium-based browsers May 9, 2026
dadezzz pushed a commit to dadezzz/university_notes that referenced this pull request May 12, 2026
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@astrojs/starlight](https://starlight.astro.build) ([source](https://github.com/withastro/starlight/tree/HEAD/packages/starlight)) | [`0.38.5` → `0.39.2`](https://renovatebot.com/diffs/npm/@astrojs%2fstarlight/0.38.5/0.39.2) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@astrojs%2fstarlight/0.39.2?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@astrojs%2fstarlight/0.38.5/0.39.2?slim=true) |

---

### Release Notes

<details>
<summary>withastro/starlight (@&#8203;astrojs/starlight)</summary>

### [`v0.39.2`](https://github.com/withastro/starlight/blob/HEAD/packages/starlight/CHANGELOG.md#0392)

[Compare Source](https://github.com/withastro/starlight/compare/@astrojs/starlight@0.39.1...@astrojs/starlight@0.39.2)

##### Patch Changes

- [#&#8203;3890](withastro/starlight#3890) [`2d05e18`](withastro/starlight@2d05e18) Thanks [@&#8203;tats-u](https://github.com/tats-u)! - Fixes CSS selector for `text-autospace` styles in Chromium browsers

### [`v0.39.1`](https://github.com/withastro/starlight/blob/HEAD/packages/starlight/CHANGELOG.md#0391)

[Compare Source](https://github.com/withastro/starlight/compare/@astrojs/starlight@0.39.0...@astrojs/starlight@0.39.1)

##### Patch Changes

- [#&#8203;3885](withastro/starlight#3885) [`010eed1`](withastro/starlight@010eed1) Thanks [@&#8203;ArmandPhilippot](https://github.com/ArmandPhilippot)! - Fixes the version mentioned in an error message related to autogenerated sidebar groups support.

- [#&#8203;3887](withastro/starlight#3887) [`b3c6990`](withastro/starlight@b3c6990) Thanks [@&#8203;delucis](https://github.com/delucis)! - Adds 13 new icons: `clock`, `desktop`, `mobile-android`, `window`, `database`, `server`, `code-branch`, `notes`, `question`, `question-circle`, `analytics`, `padlock`, and `solidjs`.

### [`v0.39.0`](https://github.com/withastro/starlight/blob/HEAD/packages/starlight/CHANGELOG.md#0390)

[Compare Source](https://github.com/withastro/starlight/compare/@astrojs/starlight@0.38.5...@astrojs/starlight@0.39.0)

##### Minor Changes

- [#&#8203;3618](withastro/starlight#3618) [`dcf6d09`](withastro/starlight@dcf6d09) Thanks [@&#8203;HiDeoo](https://github.com/HiDeoo)! - **⚠️ BREAKING CHANGE:** This release changes how autogenerated links work in Starlight’s sidebar configuration.

  If you have sidebar groups using the `autogenerate` key, you must now wrap that configuration in an `items` array:

  ```diff
  {
      label: 'My group',
  -   autogenerate: { directory: 'some-dir' },
  +   items: [{ autogenerate: { directory: 'some-dir' } }],
  }
  ```

  This change unlocks the possibility to mix autogenerated links and other links in a single group, for example:

  ```js
  {
    label: 'Mixed group',
    items: [
      'example-page',
      { autogenerate: { directory: 'examples' } },
      { label: 'More examples', link: 'https://example.com' },
    ],
  }
  ```

  This release also updates the shape of autogenerated sidebar entries in route data. Autogenerated links and groups in `Astro.locals.starlightRoute.sidebar` now include an `autogenerate` object with the [configured `directory` value](https://starlight.astro.build/guides/sidebar/#autogenerated-groups):

  ```js
  {
    type: 'link',
    label: 'Example',
    href: '/examples/example/',
    isCurrent: false,
    autogenerate: { directory: 'examples' }
  }
  ```

- [#&#8203;3618](withastro/starlight#3618) [`dcf6d09`](withastro/starlight@dcf6d09) Thanks [@&#8203;HiDeoo](https://github.com/HiDeoo)! - **⚠️ BREAKING CHANGE:** This release changes the default collapsed state of autogenerated sidebar subgroups.

  Autogenerated subgroups no longer inherit the `collapsed` value from their parent group. They are now expanded by default unless explicitly configured with [`autogenerate.collapsed`](https://starlight.astro.build/reference/configuration/#collapsing-groups).

  If your sidebar configuration relies on a collapsed parent group to also collapse its autogenerated subgroups, update your configuration to set `autogenerate.collapsed` to `true`:

  ```diff
  {
    label: 'Reference',
    collapsed: true,
    items: [
  -   { autogenerate: { directory: 'reference' } },
  +   { autogenerate: { directory: 'reference', collapsed: true } },
    ],
  }
  ```

- [#&#8203;3845](withastro/starlight#3845) [`4d755f5`](withastro/starlight@4d755f5) Thanks [@&#8203;delucis](https://github.com/delucis)! - Adds a `<link rel="alternate" hreflang="x-default" href="...">` tag pointing to the default locale in multilingual sites. The `x-default` alternate is used as a signal of which language to fall back to if no other is available. Learn more in Google’s [SEO localization docs](https://developers.google.com/search/docs/specialty/international/localized-versions#xdefault).

- [#&#8203;3862](withastro/starlight#3862) [`ec70630`](withastro/starlight@ec70630) Thanks [@&#8203;itrew](https://github.com/itrew)! - Makes spacing of items in nested lists more consistent

- [#&#8203;3872](withastro/starlight#3872) [`417a66c`](withastro/starlight@417a66c) Thanks [@&#8203;tats-u](https://github.com/tats-u)! - Enables [the CSS property `text-autospace`](https://developer.mozilla.org/docs/Web/CSS/Reference/Properties/text-autospace) in Chinese and Japanese documents.

  If you would prefer to disable autospacing in Chinese and Japanese pages, you can add the following custom CSS to your site:

  ```css
  [lang]:where(:lang(zh, ja)) {
    text-autospace: initial;
  }
  ```

- [#&#8203;3797](withastro/starlight#3797) [`9764ebd`](withastro/starlight@9764ebd) Thanks [@&#8203;delucis](https://github.com/delucis)! - Avoids the risk of layout shift when users expand and collapse sidebar groups

  This release can introduce additional padding to the site sidebar on certain devices to reserve space for scrollbars. You may wish to inspect your site sidebar visually when upgrading.

  If you would prefer to keep the previous styling, you can add the following custom CSS to your site:

  ```css
  .sidebar-pane {
    scrollbar-gutter: auto;
  }
  ```

- [#&#8203;3858](withastro/starlight#3858) [`6672c35`](withastro/starlight@6672c35) Thanks [@&#8203;delucis](https://github.com/delucis)! - Updates `i18next`, used for Starlight’s localization APIs, from v23 to v26

  There should not be any user-facing changes from this update

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNjAuNyIsInVwZGF0ZWRJblZlciI6IjQzLjE3MC4yMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants