Skip to content

i18n(vi): add Vietnames translation for Starlight UI#807

Merged
delucis merged 6 commits into
withastro:mainfrom
area44:vietnameses-translation
Oct 6, 2023
Merged

i18n(vi): add Vietnames translation for Starlight UI#807
delucis merged 6 commits into
withastro:mainfrom
area44:vietnameses-translation

Conversation

@torn4dom4n
Copy link
Copy Markdown
Contributor

@torn4dom4n torn4dom4n commented Oct 4, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

  • Add Vietnamese translation for Starlight UI

I'm taking part in Hacktoberfest.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 4, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: fd7d639

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Oct 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Oct 5, 2023 11:06pm

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 4, 2023 •
edited
Loading

👷 Deploy Preview for astro-starlight processing.

Name Link
🔨 Latest commit fd7d639
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/651f40ef73864f0008e1dd6b

@github-actions github-actions Bot added the 🌟 core Changes to Starlight’s main package label Oct 4, 2023
@torn4dom4n torn4dom4n changed the title add Vietnames translation for Starlight UI i18n(vi): add Vietnames translation for Starlight UI Oct 4, 2023
@HiDeoo HiDeoo added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 5, 2023
HiDeoo
HiDeoo reviewed Oct 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🙌

From a purely technical point of view, adding a new language will require 2 additional changes:

If needed, this PR adding the Swedish language can be used as a reference.

I've added the Hacktoberfest label.

@github-actions github-actions Bot added the 📚 docs Documentation website changes label Oct 5, 2023
@torn4dom4n
Copy link
Copy Markdown
Contributor Author

torn4dom4n commented Oct 5, 2023

@HiDeoo Everything is ready.

HiDeoo
HiDeoo requested changes Oct 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

Left a small suggestion for the changeset but except that, this looks good to me 👍

Comment thread .changeset/good-ways-jump.md Outdated
delucis
delucis reviewed Oct 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @torn4dom4n! Thanks again for making this PR.

One more tiny thing from me, but that and @HiDeoo’s suggestion should be all that’s left to ship this 🚀

Comment thread docs/src/content/docs/guides/i18n.mdx Outdated
@torn4dom4n @HiDeoo
Update .changeset/good-ways-jump.md
37487fd 
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
torn4dom4n and others added 2 commits October 6, 2023 06:03
@torn4dom4n @delucis
add comma
5c18571 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@torn4dom4n
Merge branch 'main' into vietnameses-translation
fd7d639
@torn4dom4n torn4dom4n requested review from HiDeoo and delucis October 5, 2023 23:04
delucis
delucis approved these changes Oct 5, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing those!

Looks good to go! Will merge this tomorrow as part of our next release. Thanks again for contributing this @torn4dom4n 🙌

@delucis delucis added the 🌟 patch Change that triggers a patch release label Oct 5, 2023
@torn4dom4n
Copy link
Copy Markdown
Contributor Author

torn4dom4n commented Oct 5, 2023

Happy to do some contributions for Astro 🚀

@delucis delucis merged commit 7c73dd1 into withastro:main Oct 6, 2023
@astrobot-houston astrobot-houston mentioned this pull request Oct 6, 2023
Merged
@torn4dom4n torn4dom4n deleted the vietnameses-translation branch October 6, 2023 23:24
@HiDeoo HiDeoo mentioned this pull request Oct 7, 2023
Merged
@jsparkdev jsparkdev mentioned this pull request Oct 7, 2023
Merged
@Genteure Genteure mentioned this pull request Oct 9, 2023
Merged
@morinokami morinokami mentioned this pull request Dec 2, 2023
Merged
Yoxnear pushed a commit to Yoxnear/starlight-custom that referenced this pull request Jul 23, 2025
@torn4dom4n @HiDeoo @delucis
i18n(vi): add Vietnames translation for Starlight UI (withastro#807)
ca99060 
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees

No one assigned

Labels

🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest 🌟 patch Change that triggers a patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@torn4dom4n @delucis @HiDeoo