Skip to content

Add Nostalgist.js docs to showcase#900

Merged
HiDeoo merged 2 commits into
withastro:mainfrom
arianrhodsandlot:main
Oct 15, 2023
Merged

Add Nostalgist.js docs to showcase#900
HiDeoo merged 2 commits into
withastro:mainfrom
arianrhodsandlot:main

Conversation

@arianrhodsandlot
Copy link
Copy Markdown
Contributor

@arianrhodsandlot arianrhodsandlot commented Oct 14, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

Add Nostalgist.js docs to showcase

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Oct 14, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0262b0a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 14, 2023 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 0262b0a
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/652b3451754d93000804d247
😎 Deploy Preview https://deploy-preview-900--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions Bot added the 📚 docs Documentation website changes label Oct 14, 2023
astrobot-houston
astrobot-houston reviewed Oct 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

HiDeoo
HiDeoo reviewed Oct 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great addition to the showcase.

Would you be able to update the thumbnail image to be 800 × 450 to match the dimensions of the other thumbnails in the showcase?

@arianrhodsandlot
Copy link
Copy Markdown
Contributor Author

arianrhodsandlot commented Oct 14, 2023

Done 🚀

HiDeoo
HiDeoo approved these changes Oct 14, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update 🙌

@HiDeoo HiDeoo merged commit 36fc584 into withastro:main Oct 15, 2023
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Oct 15, 2023
@HiDeoo
Merge branch 'main' into hd-docs-social-links
236c48f 
* main: (42 commits)
  docs: refactor sidebar label translations examples to use tags with regional subtags (withastro#881)
  Add Nostalgist.js docs to showcase (withastro#900)
  i18n(id): Fix environmental-impact.md translation (withastro#899)
  i18n(es): Update `customization.mdx`, `i18n.mdx` & `configuration.md` (withastro#897)
  i18n(ko): update `configuration.md` (withastro#896)
  i18n(ko): update `i18n.mdx` (withastro#895)
  i18n(ko): update `customization.mdx` (withastro#894)
  [ci] format
  i18n(id): translate guides/components.mdx and guides/project-structure.mdx (withastro#898)
  [ci] format
  [ci] release (withastro#865)
  Add Patreon social link (withastro#892)
  [ci] format
  Add Ukrainian language support (withastro#891)
  i18n(id): Translate more pages and improve existing translations (withastro#859)
  [ci] format
  feat: add Reddit social icon (withastro#854)
  [ci] format
  i18n(ru): added translations for components, css-and-tailwind, environmental-impact, project-structure pages (withastro#888)
  i18n(id): translate `guides/authoring-content.md` (withastro#863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astrobot-houston astrobot-houston astrobot-houston left review comments

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees

No one assigned

Labels

📚 docs Documentation website changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arianrhodsandlot @HiDeoo @astrobot-houston