Skip to content

feat: Bump pnpm to 10.17 and configure minimumReleaseAge#164

Merged
Adammatthiesen merged 4 commits into
mainfrom
feat/pnpm-version-bump
Sep 26, 2025
Merged

feat: Bump pnpm to 10.17 and configure minimumReleaseAge#164
Adammatthiesen merged 4 commits into
mainfrom
feat/pnpm-version-bump

Conversation

@louisescher
Copy link
Copy Markdown
Member

@louisescher louisescher commented Sep 18, 2025

Description

This PR bumps the PNPM version to 10.17.0 and enables the new minimumReleaseAge feature.

Summary by CodeRabbit

  • New Features
    • None
  • Bug Fixes
    • None
  • Chores
    • Updated Node and package manager requirements.
    • Major dependency refresh: replaced and reorganized many packages toward modern content/site tooling and typings.
    • Added workspace configuration and install/build overrides to improve installs and releases.
    • Adjusted tooling configs: switched schema validation to bundled schema, removed a plugin reference, and updated dependency-ignore lists.

@louisescher louisescher requested a review from a team as a code owner September 18, 2025 16:51
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 18, 2025

Deploy Preview for studiocms-dev-docs ready!

Name Link
🔨 Latest commit 93714be
🔍 Latest deploy log https://app.netlify.com/projects/studiocms-dev-docs/deploys/68d709ecab05e000072b1a55
😎 Deploy Preview https://deploy-preview-164--studiocms-dev-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Sep 18, 2025

📝 Walkthrough

Walkthrough

Update Node and pnpm versions, adjust prototools and biome configuration, overhaul dependencies and package manager settings in package.json, add pnpm workspace configuration and knip ignores. No source-code, control-flow, or public API changes.

Changes

Cohort / File(s) Summary
Runtime version bumps
./.node-version, ./.prototools
Update Node from 20.14.0 to 22.19.0 and pnpm from 9.5.0 to 10.17.0.
Tooling preset cleanup
./.prototools
Remove Biome version and the Biome plugin entry from prototools config.
Biome schema path update
./biome.json
Replace remote $schema URL with local node_modules schema path; other biome settings unchanged.
Dependency and tooling refactor
./package.json
Replace and expand dependencies/devDependencies (large shift toward Astro, DocSearch, MD/MDX tooling, TypeScript/typedoc tooling, and various utilities); update engines and packageManager; add pnpm overrides/onlyBuiltDependencies list.
Workspace setup
./pnpm-workspace.yaml
Add pnpm workspace file declaring packages (including .), onlyBuiltDependencies list, minimumReleaseAge and exclude patterns.
Knip config updates
./knip.config.ts
Add ignored dependencies (effect, @withstudiocms/component-registry, @docsearch/js); remove biome.json from entry/project globs.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • Beta.24 docs #158 — Similar updates touching package.json, Node/pnpm versions, and biome/tooling entries.

Suggested reviewers

  • RATIU5

Poem

I twitch my whiskers at versioned skies,
New Node and pnpm — swift little sighs.
Biome tucked close beside my den,
A workspace burrow for packages and men.
I nibble new deps and hop anew — code carrots for the crew. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly and concisely reflects the main intent of the pull request—upgrading pnpm to 10.17 and enabling the minimumReleaseAge feature—without unnecessary detail or ambiguity, aligning with the author’s stated objectives.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/pnpm-version-bump

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should try applying the suggestions given by the knip workflow 😄

@Adammatthiesen
Copy link
Copy Markdown
Member

Adammatthiesen commented Sep 24, 2025

you should try applying the suggestions given by the knip workflow 😄

wouldn't fix this issue, this is related to using pnpm-workspace-only features in a non-pnpm workspace... 😅 I'll be going through all the repos here soon to fix them.


Also... why are we updating all the deps... when we are doing this? seems a bit painful... esp because i can tell ya now our docs are running a older version of quite a few things, that need to be tested before doing updates...

Copy link
Copy Markdown
Member

@Adammatthiesen Adammatthiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on hold

@louisescher
Copy link
Copy Markdown
Member Author

Also... why are we updating all the deps... when we are doing this?

Good question. Seems that was automatically done by PNPM, I didn't do it manually

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c1da28 and 234b2ba.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (5)
  • .node-version (1 hunks)
  • .prototools (1 hunks)
  • biome.json (1 hunks)
  • package.json (2 hunks)
  • pnpm-workspace.yaml (1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
pnpm-workspace.yaml

[error] 1-1: wrong new line character: expected \n

(new-lines)

🪛 GitHub Actions: ci - Knip Lint
biome.json

[warning] 1-1: Configuration hints: Refine project pattern (no matches) in knip configuration.

package.json

[warning] 34-34: Unused dependency: @docsearch/js (listed in package.json:34:6).

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: Redirect rules - studiocms-dev-docs
  • GitHub Check: Header rules - studiocms-dev-docs
  • GitHub Check: Pages changed - studiocms-dev-docs
  • GitHub Check: Run Starlight Link Check
🔇 Additional comments (2)
.node-version (1)

1-1: Node.js v22.19.0 is available upstream Node.js v22.19.0 is listed in the official distribution index.

.prototools (1)

1-2: Artifacts available: Node v22.19.0 and pnpm 10.17.0. Both versions confirmed published and installable.

Comment thread package.json
Comment thread pnpm-workspace.yaml
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 234b2ba and 93714be.

📒 Files selected for processing (1)
  • knip.config.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Run Starlight Link Check

Comment thread knip.config.ts
Copy link
Copy Markdown
Member

@Adammatthiesen Adammatthiesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay everything but the lunaria workflow is working...

I believe the lunaria workflow is failing because its a pull_request_target and its trying to run using the main branch versions

@Adammatthiesen Adammatthiesen merged commit 293e234 into main Sep 26, 2025
11 of 12 checks passed
@Adammatthiesen Adammatthiesen deleted the feat/pnpm-version-bump branch September 26, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants