feat: Bump pnpm to 10.17 and configure minimumReleaseAge#164
Conversation
✅ Deploy Preview for studiocms-dev-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughUpdate Node and pnpm versions, adjust prototools and biome configuration, overhaul dependencies and package manager settings in package.json, add pnpm workspace configuration and knip ignores. No source-code, control-flow, or public API changes. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dreyfus92
left a comment
There was a problem hiding this comment.
you should try applying the suggestions given by the knip workflow 😄
wouldn't fix this issue, this is related to using pnpm-workspace-only features in a non-pnpm workspace... 😅 I'll be going through all the repos here soon to fix them. Also... why are we updating all the deps... when we are doing this? seems a bit painful... esp because i can tell ya now our docs are running a older version of quite a few things, that need to be tested before doing updates... |
Good question. Seems that was automatically done by PNPM, I didn't do it manually |
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
.node-version(1 hunks).prototools(1 hunks)biome.json(1 hunks)package.json(2 hunks)pnpm-workspace.yaml(1 hunks)
🧰 Additional context used
🪛 YAMLlint (1.37.1)
pnpm-workspace.yaml
[error] 1-1: wrong new line character: expected \n
(new-lines)
🪛 GitHub Actions: ci - Knip Lint
biome.json
[warning] 1-1: Configuration hints: Refine project pattern (no matches) in knip configuration.
package.json
[warning] 34-34: Unused dependency: @docsearch/js (listed in package.json:34:6).
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Redirect rules - studiocms-dev-docs
- GitHub Check: Header rules - studiocms-dev-docs
- GitHub Check: Pages changed - studiocms-dev-docs
- GitHub Check: Run Starlight Link Check
🔇 Additional comments (2)
.node-version (1)
1-1: Node.js v22.19.0 is available upstream Node.js v22.19.0 is listed in the official distribution index..prototools (1)
1-2: Artifacts available: Node v22.19.0 and pnpm 10.17.0. Both versions confirmed published and installable.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
knip.config.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run Starlight Link Check
Adammatthiesen
left a comment
There was a problem hiding this comment.
Okay everything but the lunaria workflow is working...
I believe the lunaria workflow is failing because its a pull_request_target and its trying to run using the main branch versions
Description
This PR bumps the PNPM version to 10.17.0 and enables the new
minimumReleaseAgefeature.Summary by CodeRabbit