Skip to content

i18n(fr): translate files in storage-api#202

Merged
dreyfus92 merged 2 commits into
withstudiocms:mainfrom
ArmandPhilippot:i18n/fr-add-storage-api
Jan 23, 2026
Merged

i18n(fr): translate files in storage-api#202
dreyfus92 merged 2 commits into
withstudiocms:mainfrom
ArmandPhilippot:i18n/fr-add-storage-api

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot commented Jan 21, 2026

Description

Translates in French the files in storage-api added in #194

I hope you don't mind that the 3 files are grouped together; there wasn't much content, so I assumed it was acceptable!

Summary by CodeRabbit

  • Documentation
    • Added French Storage API docs: detailed endpoint reference for PUT/POST, an overview of the Storage API and extension manager, JavaScript helper usage with typed examples, and configuration/example snippets for storage manager integration.

✏️ Tip: You can customize this high-level summary in your review settings.

@ArmandPhilippot ArmandPhilippot requested a review from a team as a code owner January 21, 2026 14:50
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 21, 2026

📝 Walkthrough

Walkthrough

Adds three new French MDX documentation pages for the Storage API: an API endpoint reference (PUT/POST), an overview with a NoOpStorageService example and configuration, and JavaScript helper functions with TypeScript types. No code or public API changes.

Changes

Cohort / File(s) Summary
French Storage API Documentation
src/content/docs/fr/storage-api/api-endpoint.mdx, src/content/docs/fr/storage-api/index.mdx, src/content/docs/fr/storage-api/javascript-helpers.mdx
Added three localized MDX docs: endpoint reference (PUT/POST, responses, types), overview with NoOpStorageService example and config snippet, and JavaScript helper usage plus exported type list. Includes frontmatter, code samples, Asides, and ReadMore links.

Sequence Diagram(s)

(omitted — changes are documentation-only and do not introduce runtime control-flow between components)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • dreyfus92
  • louisescher

Poem

"🐰 J'ai sautillé parmi les mots et les fichiers,
Trois pages en français, bien alignées et légères.
Endpoints, helpers, exemples à partager,
Un petit pas de lapin pour mieux documenter.
Vive le stockage — hop, lecture assurée!"

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding French translations for files in the storage-api directory. It is specific, concise, and clearly summarizes the primary objective of the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@studiocms-no-reply
Copy link
Copy Markdown
Member

studiocms-no-reply commented Jan 21, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
fr/storage-api/api-endpoint.mdx Localization added, will be marked as complete.
fr/storage-api/index.mdx Localization added, will be marked as complete.
fr/storage-api/javascript-helpers.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Fix all issues with AI agents
In `@src/content/docs/fr/storage-api/api-endpoint.mdx`:
- Around line 111-112: Update the HTTP block title string to the French
localized version so it matches other translated titles: replace the code fence
title "Storage API - POST Réponse d'erreur" with "API de stockage - POST Réponse
d'erreur" in the markdown block (the triple-backtick http title header).
- Around line 87-105: Corrige le rendu des endpoints `list` et `mappings` en
évitant le mélange d’inline code et de lien qui casse les accolades : pour
`list` affiche la forme de réponse en code brut (e.g. "{ files: File[] }") puis
ajoute immédiatement après un lien vers le type `[File](`#file`)`; pour `mappings`
affiche la forme de réponse en code brut (e.g. "{ mappings: UrlMetadata[] }")
puis ajoute le lien `[UrlMetadata](`#urlmetadata`)` séparément. Modifie les
sections identifiées par les noms d’opération `list` et `mappings` pour
remplacer l’actuel mélange de backticks et liens par cette séparation (réponse
en code pur + référence au type).

In `@src/content/docs/fr/storage-api/index.mdx`:
- Around line 41-49: Remplacer le bloc JSDoc anglais décrivant le "No-Op Storage
Service" par une version en français : expliquez que c’est un service de
stockage factice implémentant l’interface StorageApiBuilderDefinition, qu’il
fournit des implémentations factices pour les points de terminaison POST et PUT
en renvoyant une réponse 501 Not Implemented, et conservez les annotations de
type `@typeParam` C et `@typeParam` R en les décrivant en français (C - type du
contexte, R - type de la réponse) ; veillez à garder la structure JSDoc
existante et les mêmes balises pour ne pas casser la génération de docs.
🧹 Nitpick comments (1)
src/content/docs/fr/storage-api/javascript-helpers.mdx (1)

22-34: Localiser les noms de variables dans l’exemple.

Les noms de variables peuvent être francisés pour la lisibilité dans un contexte pédagogique, sans toucher aux API.

📝 Diff پیشنéré
-const storageIdentifier = await resolveStorageIdentifier('storage-file://my-file.txt', {
+const identifiantStockage = await resolveStorageIdentifier('storage-file://my-file.txt', {
     baseUrl: 'https://example.com/', // Utilisez la valeur de `site` depuis "astro:config/server"
 });
 
-const storageKey = await resolveStorageKey('my-file.txt', {
+const cleStockage = await resolveStorageKey('my-file.txt', {
     baseUrl: 'https://example.com/', // Utilisez la valeur de `site` depuis "astro:config/server"
 });

Based on learnings, localize identifiers in French code examples for readability.

Comment thread src/content/docs/fr/storage-api/api-endpoint.mdx
Comment thread src/content/docs/fr/storage-api/api-endpoint.mdx Outdated
Comment thread src/content/docs/fr/storage-api/index.mdx
Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you both 🫡

@dreyfus92 dreyfus92 merged commit e31c293 into withstudiocms:main Jan 23, 2026
9 checks passed
@ArmandPhilippot
Copy link
Copy Markdown
Member Author

Ah, thanks @dreyfus92 I wasn't sure about the protocol here now I have merge right. If I got an approval, should I merge this myself or is it better to wait for you since you know French? 😅

@ArmandPhilippot ArmandPhilippot deleted the i18n/fr-add-storage-api branch January 23, 2026 23:15
@dreyfus92
Copy link
Copy Markdown
Member

Hey @ArmandPhilippot, i would normally merge docs pr, but if it has an approval already from whoever from core you should be able to merge them 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants