fix: Search modal translations#52
Merged
dreyfus92 merged 4 commits intoApr 14, 2025
Merged
Conversation
Contributor
WalkthroughThe changes update the logic for reducing DocSearch strings. A new array of exception keys— Changes
Sequence Diagram(s)sequenceDiagram
participant Reducer
participant ExceptionChecker
participant NestedBuilder
Reducer->>ExceptionChecker: Check if key is in exceptions list
alt Key is an exception
ExceptionChecker-->>Reducer: True
Reducer->>RootDict: Assign value directly at root level
else Key is not an exception
ExceptionChecker-->>Reducer: False
Reducer->>NestedBuilder: Traverse and build nested structure under modal
NestedBuilder-->>Reducer: Set value at leaf node
end
Assessment against linked issues
Possibly related PRs
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Member
|
safe to ignore knip, since its a fork |
Member
Author
|
What or who is knip? |
Member
https://github.com/withstudiocms/docs/actions/runs/14451948455/job/40526471605?pr=52 the failing workflow 😅 |
Member
Author
Oh, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The problem was in the
Search.astrooverride, where the dictionary is generated 1:1 like the values from theen.json(+ other languages) files, but most of them need to wrapped inside amodal: {}object.Summary by CodeRabbit