feat(bridge): get dr timestamp agnostic to protocol version upgrades#2534
Open
guidiaz wants to merge 4 commits intowitnet:masterfrom
Open
feat(bridge): get dr timestamp agnostic to protocol version upgrades#2534guidiaz wants to merge 4 commits intowitnet:masterfrom
guidiaz wants to merge 4 commits intowitnet:masterfrom
Conversation
guidiaz
force-pushed
the
bridge/protocol-agnostic-get-dr-timestamp
branch
from
3d9a37e to
7d4fb36
Compare
Tommytrg
reviewed
Jan 17, 2025
Comment on lines
+86
to
+88
| Err(_) => { | ||
| return None; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| Err(_) => { | |
| return None; | |
| } | |
| Err(_) => None; |
| Ok(x) => x, | ||
| Err(()) => { | ||
| log::error!("Failed to get current protocol info from witnet client, will retry later"); | ||
| return Some(witnet_consensus_constants); |
Member
There was a problem hiding this comment.
Suggested change
| return Some(witnet_consensus_constants); | |
| Some(witnet_consensus_constants) |
| Ok(result) => result, | ||
| Err(_) => { | ||
| log::error!("Failed to connect to witnet client, will retry later"); | ||
| return Err(()); |
Member
There was a problem hiding this comment.
Suggested change
| return Err(()); | |
| Err(()) |
| .expect("failed to deserialize consensus constants"), | ||
| Err(e) => { | ||
| log::error!("error in getConsensusConstants call: {:?}", e); | ||
| return Err(()); |
Member
There was a problem hiding this comment.
Suggested change
| return Err(()); | |
| Err(()) |
| log::error!("error in getConsensusConstants call: {:?}", e); | ||
| return Err(()); | ||
| log::error!("Error when getting protocol info: {:?}", e); | ||
| Err(()) |
Member
There was a problem hiding this comment.
Suggested change
| Err(()) | |
| Err(()) |
Contributor
Author
There was a problem hiding this comment.
All these "returns" are on purpose, as they're intended to exit the function, not the match block.
Tommytrg
approved these changes
Jan 17, 2025
aesedepece
force-pushed
the
master
branch
2 times, most recently
from
1679d32 to
1b59db0
Compare
aesedepece
force-pushed
the
master
branch
3 times, most recently
from
54b59f2 to
96c6d01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.