Conversation
…g the setup script to dependant projects.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Projects that depend on
react-native-notificationstrigger prepare-robolectric.gradlewhich in turn downloads all of robolectric's dependencies
downloadRobolectricDependencies into {..}/android/build/robolectric-3.5.1-dependencieswhich takes close to two minutes (!!) on every build.On newer robolectric version this issue is resolved and is handled internally, without a script.
This PR updates dependencies and specifically robolectric setup to stop leaking the setup script to dependant projects. It required update of gradle, plugins, and sdk targets to be able to compile the project (all were very old and not compatible with modern Android)