Skip to content

reduced scrollEventThrottle on android (Ticket 4885) #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZivSa1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

reduced scrollEventThrottle on android (Ticket 4885) #3856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6fa8487
reduced scrollEventThrottle on android
ZivSa1 Dec 10, 2025
3d389ce
Add ticket reference to scrollEventThrottle comment
ZivSa1 Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/components/carousel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,10 +308,9 @@ class Carousel extends Component<CarouselProps, CarouselState> {
// finished full page scroll
const {currentStandingPage, currentPage} = this.state;
const pagesCount = presenter.getChildrenLength(this.props);

if (currentPage < pagesCount) {
this.setState({currentStandingPage: currentPage});

if (currentStandingPage !== currentPage) {
this.props.onChangePage?.(currentPage, currentStandingPage, {isAutoScrolled: this.isAutoScrolled});
this.isAutoScrolled = false;
Expand Down Expand Up @@ -511,7 +510,7 @@ class Carousel extends Component<CarouselProps, CarouselState> {
showsHorizontalScrollIndicator={false}
showsVerticalScrollIndicator={false}
decelerationRate="fast"
scrollEventThrottle={200}
scrollEventThrottle={Constants.isAndroid ? 16 : 200} // Android needs 16ms throttle to reliably catch loop boundary during fast swipes (Ticket 4885)
{...others}
ref={this.carousel}
onScroll={animatedScrollOffset ? this.onScrollEvent : this.onScroll}
Expand Down