Skip to content

Fix SIOF for error-bounds and put stdx into predicates namespace #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
artem-ogre wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix SIOF for error-bounds and put stdx into predicates namespace #4

artem-ogre wants to merge 2 commits into from

Conversation

@artem-ogre
Copy link
Contributor

@artem-ogre artem-ogre commented Jul 3, 2019

  • Static error bound constants depend on static epsilon constant which lead to static initialization order fiasco
  • Insert stdx into predicates namespace to avoid the potential issue when namespace stdx is already defined in the client code

artem-ogre added 2 commits July 3, 2019 17:54
@artem-ogre
Fix SIOF for error-bounds and put stdx into predicates namespace
1336314 
- Static error bound constants depend on static epsilon constant which lead to static initialization order fiasco
- Insert 'stdx' into 'predicates' namespace to avoid the potential issue when namespace 'stdx' is already defined in the client code
@artem-ogre
Move namespace to avoid including std-headers into it
3c330a5
@artem-ogre
Copy link
Contributor Author

artem-ogre commented Oct 26, 2020 •
edited
Loading

Hi William,
I have also moved namespace predicates { to avoid including std-headers into it.
Would you be able to take a look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@artem-ogre