Disallow atomics during fence & WOLFSSL_NO_ATOMIC#9076
Merged
douzzer merged 1 commit intowolfSSL:masterfrom Aug 9, 2025
Merged
Disallow atomics during fence & WOLFSSL_NO_ATOMIC#9076douzzer merged 1 commit intowolfSSL:masterfrom
douzzer merged 1 commit intowolfSSL:masterfrom
Conversation
2c15107 to
e6ffbfb
Compare
Contributor
Author
|
Jenkins retest this please For AgentOfflineException: Unable to create live FilePath for wolf-linux-cloud-node-[n]; wolf-linux-cloud-node-[n]was marked offline: Connection was broken |
dgarske
approved these changes
Aug 8, 2025
douzzer
approved these changes
Aug 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
wc_port.hduring#ifndef WOLFSSL_NO_FENCEandWOLFSSL_NO_ATOMICthe#include <stdatomic.h>should not occur.I encountered this on the Arduino Due X (SAM3X8E) when testing wolfssl on small devices with these errors, even with
WOLFSSL_NO_ATOMIC:I suppose I could have enabled
WOLFSSL_NO_FENCE, but it seems more intuitive to actually not include<stdatomic.h>whenWOLFSSL_NO_ATOMICis defined.Fixes zd# n/a
Testing
How did you test?
Tested only on
__SAM3X8E__in question, and a briefmakein Linux.Checklist