-
Notifications
You must be signed in to change notification settings - Fork 843
[로또] 김믿음 과제 제출합니다. #846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pleasebelieveme
wants to merge
39
commits into
woowacourse-precourse:main
Choose a base branch
from
pleasebelieveme:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[로또] 김믿음 과제 제출합니다. #846
+2,874
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat(readme): 리드미 초안 작성
1. parsor 패키지 분리 2. 예외처리 정의
Pleasebelieveme
feat(domain): Lotto 객체 기본 기능 구현
feat(domain): LottoTickets 객체 구현
feat(domain): LottoResult 객체 구현
feat(parser): 구매 금액 파싱 구현
feat(parser): 당첨 번호 파싱 구현
feat(parser): 보너스 번호 파싱 구현(추후 Parser 리팩토링 필요!)
feat(validator): 구매 금액 검증 구현
feat(validator): 당첨 번호 검증 구현
feat(validator): 보너스 번호 검증 구현
feat(util): 구매 금액에 따른 자동 로또 생성 기능 구현 (LottoGenerator)
feat: 최종 과제물
fix: LottoTickets 주석해제
fix: 3.1 validator까지 수정완료
feat(common): LottoConstants 공통 상수 클래스 생성, 에러메세지도 공통 상수를 사용할껀지 고민
fix: 에러메세지 상수 사용
fix: 기능 개발 완료, Service는 View만 있기에 테스트를 안해도 상관 없음
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.