[빙봉] 블랙잭 2단계 미션 제출합니다. #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
블랙잭 2단계 하는 중 PR
… 있도록 수정, 블랙잭을 판별하기 위한 Participant 인터페이스에 countHand() 메서드 추가
hongsii
suggested changes
Mar 20, 2020
hongsii
left a comment
hongsii
left a comment
There was a problem hiding this comment.
1단계 피드빅 반영 및 2단계도 잘 구현해주셨네요! 👍
몇 가지 피드백 드렸으니, 확인하셔서 반영해주세요~
| this.players = splitNames(names); | ||
| } | ||
|
|
||
| public void initMoney(List<String> moneys, MoneyResult moneyResult) { |
There was a problem hiding this comment.
MoneyResult 를 파라미터로 전달하지 않고 여기서 생성해도 되지 않을까요?
Author
There was a problem hiding this comment.
Players에서 MoneyResult를 생성해도 되지만 MoneyResult를 생성하는 것이 Players 클래스의 역할이라 보기 어렵다고 생각했습니다. 어디에 들어가도 애매할 것 같아 Controller로 뺐었는데 Players의 역할이라고 봐도 괜찮을까요?
There was a problem hiding this comment.
말씀하신대로 역할이 애매하다면 스스로 초기화를 책임져도 좋을 것 같아요!
MoneyResult 의 정적 팩토리 메서드에 getter로 필요한 값(Players)을 파라미터로 전달해 생성했어도 좋았을 것 같습니다.
…ame() 메서드로 넣도록 수정
… 코드 작성 및 테스트 코드 추가
hongsii
approved these changes
Mar 25, 2020
hongsii
left a comment
hongsii
left a comment
There was a problem hiding this comment.
피드백 반영을 잘 해주셨습니다! 👍
코멘트 남겼으니 확인해주세요. 이번 단계는 머지하겠습니다!
미션 진행하시느라 고생많으셨습니다 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
많은 피드백 부탁드립니다! 감사합니다!!