Skip to content

Support standard bullet styles#1409

Merged
twstokes merged 12 commits intowordpress-mobile:developfrom
cbess:ul-indent-styles
Apr 5, 2025
Merged

Support standard bullet styles#1409
twstokes merged 12 commits intowordpress-mobile:developfrom
cbess:ul-indent-styles

Conversation

@cbess
Copy link
Contributor

@cbess cbess commented Feb 22, 2025 •
edited by twstokes
Loading

Reopening: #1354

  • Addressed each point in the above PR.
  • Added alternate ordered list style support per level

Similar to web browsers, draw different bullets at different levels.

To test:

  • Set the listIndentStyle to .varied
  • Create an ordered or unordered list
  • Add multiple levels to it
  • Notice the bullet style for level one is different than level two and three
  • Also, execute "Big Lists" demo, works as expected
Before After
old new
Screenshot 2025-02-22 at 4 53 29 PM Screenshot 2025-02-22 at 4 52 42 PM
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

cbess added 9 commits March 28, 2022 19:47
@cbess
support alternate bullet style per level
380523a 
similar to web browsers, draw different bullets at different levels
@cbess
cleanup whitespace
4f27745
@cbess
Squashed commit of the following:
08c85ec 
commit 4d0522d
Merge: 2b54f87 59d5090
Author: Gio Lodi <gio.lodi@automattic.com>
Date:   Thu Mar 9 12:08:36 2023 +1100

    Point `bash-cache` plugin to new `a8c-ci-toolkit` location (wordpress-mobile#1367)

commit 59d5090
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Mar 6 21:10:15 2023 +1100

    Remove unused YAML anchor and fix indentation in pipeline

commit e0526bf
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Mar 6 21:09:53 2023 +1100

    Point `bash-cache` plugin to new `a8c-ci-toolkit` location

    While I was at it, I also updated the version to the latest, 2.13.0.

    This was done via:

    ```
    find . -type f -name "*.yml" -exec sed -i '' 's/automattic\/bash-cache#[0-9.]\{1,\}/automattic\/a8c-ci-toolkit#2.13.0/g' {} +
    ```

commit 2b54f87
Merge: b7d8a70 d18d0a8
Author: Gio Lodi <giovanni.lodi42@gmail.com>
Date:   Thu Oct 20 16:59:18 2022 +1100

    Add `CHANGELOG.md` (wordpress-mobile#1365)

commit d18d0a8
Author: Gio Lodi <gio@mokacoding.com>
Date:   Thu Oct 20 15:18:16 2022 +1100

    Update `PULL_REQUEST_TEMPLATE.md` with note about `CHANGELOG.md`

commit 2c73ef5
Author: Gio Lodi <gio@mokacoding.com>
Date:   Thu Oct 20 14:32:38 2022 +1100

    Add changelog entry about changelog itself

commit 212ce2f
Author: Gio Lodi <gio@mokacoding.com>
Date:   Thu Oct 20 14:15:12 2022 +1100

    Update `CHANGELOG.md` with new format

commit b7d8a70
Merge: 91cf065 40afa55
Author: Gio Lodi <giovanni.lodi42@gmail.com>
Date:   Tue Oct 4 10:29:42 2022 +1100

    Tools upgrade: Ruby 2.7.4, bash-cache 2.8.0 (wordpress-mobile#1363)

commit 40afa55
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Oct 3 20:00:33 2022 +1100

    Use `bash-cache` Buildkite plugin version 2.8.0

    This version includes a fix that removes the need to run
    `gem install bundler` before each step.

commit bd8840a
Author: Gio Lodi <gio@mokacoding.com>
Date:   Mon Oct 3 19:59:52 2022 +1100

    Use Ruby version 2.7.4

commit 91cf065
Merge: 9d8d9b8 1ce621c
Author: Diego Rey Mendez <diegoreymendez@users.noreply.github.com>
Date:   Wed Aug 10 15:07:41 2022 +0200

    Merge pull request wordpress-mobile#1353 from cbess/expose-indentation-actions

    Expose indentation operations

commit 9d8d9b8
Merge: b16c763 7eb60c7
Author: Tony Li <i@crazytony.li>
Date:   Mon Jul 25 11:11:13 2022 +1200

    Merge pull request wordpress-mobile#1359 from wordpress-mobile/remove/circle-ci

    Remove CircleCI

commit 7eb60c7
Author: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>
Date:   Fri Jul 22 23:23:27 2022 -0600

    Trigger Build

commit f91511e
Author: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>
Date:   Thu Jul 21 23:03:28 2022 -0600

    Remove CircleCI

commit 1ce621c
Author: C. Bess <cbess@users.noreply.github.com>
Date:   Sat Mar 26 12:31:51 2022 -0500

    cleanup whitespace

commit ed55d4a
Author: C. Bess <cbess@users.noreply.github.com>
Date:   Sat Mar 26 12:31:03 2022 -0500

    cleanup whitespace

commit 4561534
Author: C. Bess <cbess@users.noreply.github.com>
Date:   Sat Mar 26 12:01:30 2022 -0500

    expose indentation operations

    - make increase/decrease indentation actions visible
    - cleanup code
@cbess
add TextList.IndentStyle
2b59a4d 
- support indent style option
@cbess
satisfy hound
9568191
@cbess
Merge branch 'develop' into ul-indent-styles
49a5925
@cbess
Merge branch 'develop' into ul-indent-styles
b2c706c
@cbess
support multi-style ordered list
5f45e62 
- support html-style order list, using alphabets and roman numerals
- cleanup code
@cbess
Update CHANGELOG.md
3e03ddf
@cbess cbess mentioned this pull request Feb 22, 2025
Closed
@cbess cbess marked this pull request as ready for review February 22, 2025 23:08
@cbess
Copy link
Contributor Author

cbess commented Feb 22, 2025

@twstokes it should be ready now :)

@cbess cbess changed the title RE: Support alternate bullet style per level Support standard bullet styles Feb 23, 2025
@twstokes
Copy link
Contributor

twstokes commented Feb 25, 2025

@twstokes it should be ready now :)

Sounds good @cbess! I'll aim to look at it soon.

@twstokes twstokes self-requested a review February 25, 2025 15:44
@cbess
Copy link
Contributor Author

cbess commented Mar 30, 2025

@twstokes any updates?

@twstokes twstokes mentioned this pull request Mar 30, 2025
Closed
twstokes
twstokes reviewed Mar 30, 2025
View reviewed changes
twstokes
twstokes reviewed Mar 31, 2025
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbess thanks for your work on this.

The only part I'm unsure of is ordered lists:

Similar to web browsers, draw different bullets at different levels.

The HTML spec supports different bullet styles as you mentioned for ordered lists, but in my testing browsers are rendering what Aztec is already doing by default.

I tested Chrome and Safari with:

<ol>
  <li>One</li>
  <ol>
    <li>Two</li>
    <ol>
      <li>Three</li>
    </ol>
  </ol>
</ol>

And it renders:

image

This is also reflected in the MDN docs. Lastly, I get the same behavior in the iOS Notes app for ordered list nesting. I think in order to fully support ordered list styles we'd need to let the user choose them and have the appropriate HTML markup reflect the choice. If I'm misunderstanding something please let me know.

For unordered lists I think your changes work well in that they vary the bullets styles, which seems to be standard behavior. 👍

@cbess
Copy link
Contributor Author

cbess commented Apr 1, 2025

@twstokes You're welcome! I appreciate this library, thanks for maintaining it!

You make a fair point about the ol bullets. And yes, that was intentional. I should have said:

Similar to popular wysiwyg HTML editors, draw different bullets at different levels.

I was really copying examples like CKEditor 😅

Screenshot 2025-03-31 at 5 44 48 PM

With that being said, perhaps the style can be renamed to mixed or varied or assorted or multiform or [something else]?

@twstokes
Copy link
Contributor

twstokes commented Apr 1, 2025

With that being said, perhaps the style can be renamed to mixed or varied or assorted or multiform or [something else]?

varied makes sense to me. 👍

@cbess
Copy link
Contributor Author

cbess commented Apr 2, 2025 •
edited
Loading

Updated enum member and the doc string

twstokes
twstokes approved these changes Apr 5, 2025
View reviewed changes
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @cbess!

@twstokes twstokes merged commit 8dea1ea into wordpress-mobile:develop Apr 5, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@twstokes twstokes twstokes approved these changes

Assignees

No one assigned

Labels

[Type] Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cbess @twstokes