Skip to content

fix: Scrolling along edges breaks text editing #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcalhoun merged 1 commit into from
May 19, 2025
Merged

fix: Scrolling along edges breaks text editing #135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions patches/@wordpress+rich-text+7.22.0.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
diff --git a/node_modules/@wordpress/rich-text/build-module/component/event-listeners/prevent-focus-capture.js b/node_modules/@wordpress/rich-text/build-module/component/event-listeners/prevent-focus-capture.js
index 3b885f5..c2ea3d0 100644
--- a/node_modules/@wordpress/rich-text/build-module/component/event-listeners/prevent-focus-capture.js
+++ b/node_modules/@wordpress/rich-text/build-module/component/event-listeners/prevent-focus-capture.js
@@ -36,9 +36,11 @@ export function preventFocusCapture() {
}
defaultView.addEventListener('pointerdown', onPointerDown);
defaultView.addEventListener('pointerup', onPointerUp);
+ defaultView.addEventListener('pointercancel', onPointerUp);
return () => {
defaultView.removeEventListener('pointerdown', onPointerDown);
defaultView.removeEventListener('pointerup', onPointerUp);
+ defaultView.removeEventListener('pointercancel', onPointerUp);
};
};
}
4 changes: 4 additions & 0 deletions patches/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,7 @@ Existing patches should be described and justified here.

- Expose an `open` prop on the `Inserter` component, allowing toggling the inserter visibility via the quick inserter's "Browse all" button.
- Disable `stripExperimentalSettings` in the `BlockEditorProvider` component so that the Patterns and Media inserter tabs function.

### `@wordpress/rich-text`

- Fix `preventFocusCapture` causing uneditable text blocks on touch devices when scrolling by swiping outside of the block canvas--e.g., along the edge of the screen.