Fix WebView Memory Leak in GutenbergView#156
Merged
Conversation
…dow() WebViews were lingering in Chrome inspector after closing the editor because GutenbergView.onDetachedFromWindow() cleaned up listeners but didn't call WebView.destroy(). Adding this.destroy() ensures WebViews are properly disposed of when detached from the window hierarchy.
oguzkocer
changed the title
GutenbergView
oguzkocer
changed the title
GutenbergViewWebView Memory Leak in GutenbergView
dcalhoun
approved these changes
Jul 17, 2025
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Verified the memory leak is fixed. Thanks!
oguzkocer
deleted the
followup-to-allow-multiple-sites-in-android-demo-app
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #155 that addresses
WebViewmemory leaks inGutenbergView.Changes
this.destroy()call toGutenbergView.onDetachedFromWindow()to properly dispose ofWebViews when detached from window hierarchy.setSiteApiNamespace(arrayOf("wp/v2"))call as it's only needed for WPCOM sites using the WPCOM APITesting
chrome://inspectWebViewappears in inspector while editor is openWebViewdisappears from Chrome inspectorWebViewappears in inspectorBefore this fix,
WebViews would accumulate in the inspector after closing the editor.