-
Notifications
You must be signed in to change notification settings - Fork 3
feat: AJAX uses token authentication #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dcalhoun
wants to merge
10
commits into
trunk
Choose a base branch
from
feat/authorize-ajax-with-application-passwords
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
370a33d
feat: Authorize AJAX with application passwords
dcalhoun 9a6e8c0
refactor: Rename AJAX and api-fetch configuration utilities
dcalhoun fbe3f59
fix: Configure AJAX after the library loads
dcalhoun 2067796
test: Fix test imports and assertions
dcalhoun 88abb5a
fix: Set the global WordPress admin AJAX URL
dcalhoun ac0ecd0
test: Assert AJAX configuration
dcalhoun 20ec356
feat: Allow configuring the Android asset loader domain
dcalhoun a17a7fb
docs: Note AJAX support requirements
dcalhoun 64d4eb1
docs: Note AJAX CORS errors in troubleshooting documentation
dcalhoun ea73b3c
fix: Add type checks before wrapping wp.ajax methods (#282)
dcalhoun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,84 @@ | ||
| /** | ||
| * Internal dependencies | ||
| */ | ||
| import { getGBKit } from './bridge'; | ||
| import { warn, debug } from './logger'; | ||
|
|
||
| /** | ||
| * GutenbergKit lacks authentication cookies required for AJAX requests. | ||
| * This configures a root URL and authentication header for AJAX requests. | ||
| * | ||
| * @return {void} | ||
| */ | ||
| export function configureAjax() { | ||
| window.wp = window.wp || {}; | ||
| window.wp.ajax = window.wp.ajax || {}; | ||
| window.wp.ajax.settings = window.wp.ajax.settings || {}; | ||
|
|
||
| const { siteURL, authHeader } = getGBKit(); | ||
| configureAjaxUrl( siteURL ); | ||
| configureAjaxAuth( authHeader ); | ||
| } | ||
|
|
||
| function configureAjaxUrl( siteURL ) { | ||
| if ( ! siteURL ) { | ||
| warn( 'Unable to configure AJAX URL without siteURL' ); | ||
| return; | ||
| } | ||
|
|
||
| // Global used within WordPress admin pages | ||
| window.ajaxurl = `${ siteURL }/wp-admin/admin-ajax.php`; | ||
| // Global used by WordPress' JavaScript API | ||
| window.wp.ajax.settings.url = `${ siteURL }/wp-admin/admin-ajax.php`; | ||
|
|
||
| debug( 'AJAX URL configured' ); | ||
| } | ||
|
|
||
| function configureAjaxAuth( authHeader ) { | ||
| if ( ! authHeader ) { | ||
| warn( 'Unable to configure AJAX auth without authHeader' ); | ||
| return; | ||
| } | ||
|
|
||
| window.jQuery?.ajaxSetup( { | ||
| headers: { | ||
| Authorization: authHeader, | ||
| }, | ||
| } ); | ||
dcalhoun marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| if ( typeof window.wp.ajax.send === 'function' ) { | ||
| const originalSend = window.wp.ajax.send; | ||
| window.wp.ajax.send = function ( options ) { | ||
| const originalBeforeSend = options.beforeSend; | ||
|
|
||
| options.beforeSend = function ( xhr ) { | ||
| xhr.setRequestHeader( 'Authorization', authHeader ); | ||
|
|
||
| if ( typeof originalBeforeSend === 'function' ) { | ||
| originalBeforeSend( xhr ); | ||
| } | ||
| }; | ||
|
|
||
| return originalSend.call( this, options ); | ||
| }; | ||
| } | ||
|
|
||
| if ( typeof window.wp.ajax.post === 'function' ) { | ||
| const originalPost = window.wp.ajax.post; | ||
| window.wp.ajax.post = function ( options ) { | ||
| const originalBeforeSend = options.beforeSend; | ||
|
|
||
| options.beforeSend = function ( xhr ) { | ||
| xhr.setRequestHeader( 'Authorization', authHeader ); | ||
|
|
||
| if ( typeof originalBeforeSend === 'function' ) { | ||
| originalBeforeSend( xhr ); | ||
| } | ||
| }; | ||
|
|
||
| return originalPost.call( this, options ); | ||
| }; | ||
| } | ||
|
|
||
| debug( 'AJAX auth configured' ); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.