Merged
Conversation
Communicate the destination position for a dragged block. The popover used for this feature was hidden previously because it disrupts tap/click events in the block inserter, requiring two taps to insert a block. These changes continue hiding the "add block" button popover displayed alongside empty text blocks, but allows the insertion point indicator to now be displayed. We disable the insertion point display from the block inserter only by detecting touch devices (as best possible) and prevent the relevant `onMouseEnter` event callback triggering the `onHover` callback.
5840a62 to
2ec7357
Compare
kean
approved these changes
Nov 5, 2025
Contributor
There was a problem hiding this comment.
I'm surprised how drag-n-drop works in a web view, even on a device. I just want to share a couple of small observations and potential things to improve:
- "Gallery" seems to indicate a drop target for itself
- As you drag your finger the insertion point gets continuously animated (appear/disappear) even if there is no change
- The insertion points disappears over some blocks. For example, if you hold your finger over
core/block, the insertion point is always shown as the closest to your finger. If you do it overcore/list, it disappears - I tried using drag-n-drop for text the same way as you can do in the Notes app, and it didn't work.
test-device.mov
Member
Author
|
Captured the reported improvement opportunities in CMM-936-linear-issue. Most, if not call, occur for cursor devices in the web editor, but worthwhile improvements nonetheless. Thank you for sharing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Display the block insertion point indicator when dragging blocks.
Why?
Close CMM-731. Communicate the destination position for a dragged block.
How?
The popover used for this feature was hidden previously because it
disrupts tap/click events in the block inserter, requiring two taps to
insert a block.
These changes continue hiding the "add block" button popover displayed
alongside empty text blocks, but allows the insertion point indicator to
now be displayed. We disable the insertion point display from the block
inserter only by detecting touch devices (as best possible) and prevent
the relevant
onMouseEnterevent callback triggering theonHovercallback.
Testing Instructions
1. Drag insertion point indicator is displayed
between the blocks.
2. Inserting blocks from the block inserter requires a single tap
+button open the block inserter.Accessibility Testing Instructions
N/A, no navigation changes.
Screenshots or screencast
Simulator.Screen.Recording.-.iPhone.17.-.2025-11-05.at.11.46.15.mov
Footnotes
Dragging text blocks is difficult on web due to the
contenteditablegenerally stealing focus and activate cursor/text actions. ↩