fix: Reinstate editor singleton registry#26
Merged
Conversation
This appears to already be invoked by the `EditorProvider`. The redundant invocation was likely erroneously left in place when we began using the `EditorProvider` recently. #24 https://github.com/WordPress/gutenberg/blob/219065c3be5881a68a8667fda9c04c7b7f546763/packages/editor/src/components/provider/index.js#L178
Reinstate the editor singleton registry so that third-party blocks may query the block editor state.
dcalhoun
commented
Sep 20, 2024
geriux
approved these changes
Sep 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reinstate disabling the editor sub-registry so that a singleton registry is
used. This allows third-party blocks to query the block editor state.
Additionally, remove what appears to be a redundant invocation of
getEditorSettingsthat may have been erroneously left in place during#24. It appears the
EditorProvideralready invokesgetEditorSettings.Testing Instructions
Verify the editor — local or remote — launches without errors.
Verify Jetpack AI queries that require block content succeed; e.g., requesting
Jetpack AI modify an existing block.