fix: Editor preloading survives blocked asset downloads#305
Merged
Conversation
Previously, a single failed asset download caused the entire asset bundle fail. This led to the editor displaying an error screen. Now, individual asset download failures are caught independently and other asset downloads may proceed. This is useful for instances where an asset download intermittently fails or is blocked (e.g., ad blocker).
Compose `urlResponseHandler` for specific scenarios (e.g., unique responses) rather than additional mock properties.
dcalhoun
commented
Jan 28, 2026
Comment on lines
-847
to
-848
| var downloadResponse: URL? | ||
| var shouldThrowError: Error? |
Member
Author
There was a problem hiding this comment.
Removed in favor of composing the urlResponseHandler for unique scenarios—e.g., URL-specific data and errors.
jkmassel
reviewed
Jan 29, 2026
ios/Sources/GutenbergKit/Sources/Stores/EditorAssetLibrary.swift
Outdated
Show resolved
Hide resolved
Address feedback. Improve the ability to test and debug this logic. Co-authored-by: Jeremy Massel <1123407+jkmassel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Makes the editor resilient to individual asset download failures during preloading, preventing the editor from failing to load when content blockers (like AdGuard) block analytics scripts.
Why?
Fix CMM-1179.
When AdGuard blocks
stats.wp.com/w.js, theEditorAssetLibrary.buildBundle()method was failing entirely because it usedwithThrowingTaskGroup- any single asset failure would cause the entire bundle download to fail, resulting in an "Editor Error" screen with "bad URL" message.How?
Production code (
EditorAssetLibrary.swift)buildBundle()fromwithThrowingTaskGrouptowithTaskGroupfetchAsset()to returnVoidinstead ofURL(return value was unused)Test code (
EditorAssetLibraryTests.swift)EditorAssetLibraryMockHTTPClientby:urlResponseHandlerthrowable:((URL) throws -> Data)shouldThrowErroranddownloadResponsepropertiesperform()anddownload()methodsTesting Instructions
stats.wp.comin some manner—e.g., AdGuard, Proxyman.Automated Testing
make test-swift-package- all tests pass including new testbuildBundle continues when individual asset downloads fail