Skip to content

fix: Register MediaFileSchemeHandler for native iOS media insertion #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcalhoun merged 2 commits into from
Jan 31, 2026
Merged

fix: Register MediaFileSchemeHandler for native iOS media insertion #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0acac7f
fix: Native iOS inserter inserts media
claude Jan 30, 2026
76c0546
test: Assert MediaFileSchemeHandler registration
dcalhoun Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ios/Sources/GutenbergKit/Sources/EditorViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,9 @@ public final class EditorViewController: UIViewController, GutenbergEditorContro

self.bundleProvider.bind(to: config)

// Register media file scheme handler for serving local media via gbk-media-file:// URLs
config.setURLSchemeHandler(MediaFileSchemeHandler(), forURLScheme: MediaFileSchemeHandler.scheme)

config.applicationNameForUserAgent = "GutenbergKit/\(GutenbergKitVersion.version)"

self.webView = GBWebView(frame: .zero, configuration: config)
Expand Down
25 changes: 25 additions & 0 deletions ios/Tests/GutenbergKitTests/Media/MediaFileSchemeHandlerRegistrationTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import Foundation
import Testing
import WebKit

@testable import GutenbergKit

#if canImport(UIKit)

@Suite("MediaFileSchemeHandler Registration")
struct MediaFileSchemeHandlerRegistrationTests: MakesTestFixtures {
static let testSiteURL = URL(string: "https://test.example.com")!
static let testApiRoot = URL(string: "https://test.example.com/wp-json/wp/v2")!

@MainActor
@Test("EditorViewController registers MediaFileSchemeHandler for gbk-media-file scheme")
func editorViewControllerRegistersSchemeHandler() throws {
let configuration = makeConfiguration()
let editorVC = EditorViewController(configuration: configuration)

let handler = editorVC.webView.configuration.urlSchemeHandler(forURLScheme: MediaFileSchemeHandler.scheme)
#expect(handler != nil, "MediaFileSchemeHandler should be registered for \(MediaFileSchemeHandler.scheme) scheme")
}
}

#endif
Loading