Skip to content

fix: resolve iOS E2E test failures in block inserter #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dcalhoun merged 2 commits into from
Feb 27, 2026
Merged

fix: resolve iOS E2E test failures in block inserter #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18cf90e
fix: use firstMatch in block inserter E2E test helper
dcalhoun Feb 25, 2026
c518d69
fix: always copy dist into iOS bundle for E2E tests
dcalhoun Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,10 +222,9 @@ test-ios-e2e: ## Run iOS E2E tests against the production build
else \
echo "--- :white_check_mark: Using existing build. Use 'make build REFRESH_JS_BUILD=1' to rebuild."; \
fi
@if [ ! -d "./ios/Sources/GutenbergKit/Gutenberg" ]; then \
echo "--- :open_file_folder: Copying build into iOS bundle"; \
cp -r ./dist/. ./ios/Sources/GutenbergKit/Gutenberg/; \
fi
@echo "--- :open_file_folder: Copying build into iOS bundle"
@rm -rf ./ios/Sources/GutenbergKit/Gutenberg/
@cp -r ./dist/. ./ios/Sources/GutenbergKit/Gutenberg/
@echo "--- :ios: Running iOS E2E Tests (production build)"
@set -o pipefail && \
xcodebuild test \
Expand Down
4 changes: 3 additions & 1 deletion ios/Demo-iOS/GutenbergUITests/EditorUITestHelpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ enum EditorUITestHelpers {
XCTAssertTrue(addBlockButton.waitForExistence(timeout: 10), "Add block button not found in WebView toolbar")
addBlockButton.tap()

let blockOption = app.buttons[name]
// Use firstMatch because the same block can appear in multiple
// inserter sections (e.g. most-used and its category section).
let blockOption = app.buttons[name].firstMatch
XCTAssertTrue(blockOption.waitForExistence(timeout: 10), "\(name) block not found in block inserter")
blockOption.tap()
}
Expand Down
Loading