-
Notifications
You must be signed in to change notification settings - Fork 3
feat: trigger editor savePost() lifecycle from native hosts #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dcalhoun
wants to merge
13
commits into
trunk
Choose a base branch
from
feat/save-post-lifecycle-bridge
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
6474a75
feat: add savePost() bridge to trigger editor store save lifecycle
dcalhoun 6b49fb6
feat(android): add savePost() to GutenbergView
dcalhoun 68a696c
refactor: harden savePost bridge and clarify host contract
dcalhoun 438fa6c
fix: suppress editor save snackbar in host bridge
dcalhoun 25b1f50
test: cover savePost snackbar removal in host bridge
dcalhoun cec8ae9
test: localize useDispatch mock for savePost coverage
dcalhoun 238b2dc
test: revert global useDispatch mock to its trunk shape
dcalhoun d73d5e9
docs: Reduce comment length
dcalhoun 7c0101d
fix(demo): always persist content even when savePost lifecycle fails
dcalhoun 39d3b63
fix(host-bridge): avoid returning savePost() result to hosts
dcalhoun 858f08b
fix(android): deliver savePost not-ready callback on handler thread
dcalhoun 64e2627
fix(android): prefer e.message when stringifying savePost rejections
dcalhoun aba02cb
refactor(host-bridge): rename savePost to triggerSaveLifecycle
dcalhoun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noting that invoking
savePost()may mean we cannot remove thefilterEndpointsMiddlewareas referenced in #432 (comment) and #434.It may still be worthwhile to properly seed the content, but I believe invoking
savePost()triggers aPUTrequest for the same endpoint. There may also be defense in depth by retaining the middleware.