Merged
Conversation
emilylaguna
approved these changes
Jan 27, 2020
Contributor
emilylaguna
left a comment
emilylaguna
left a comment
There was a problem hiding this comment.
- Confirmed develop is crashing on iOS 12 and below
- Confirmed this is now working on iOS 11.0 and above
- Tested: iOS 11.0.1, 11.4, 12.4, 13.3
During testing noticed some autolayout warnings which have been noted here #5
LGTM! ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
MediaEditorwas crashing in iOS 12 devices due to a difference in the API ofUINavigationController.To test
If you try the steps above in
develop, you'll see that the app crashes.