Skip to content
This repository was archived by the owner on Jun 19, 2025. It is now read-only.

Add CHANGELOG.md#396

Merged
mokagio merged 5 commits intotrunkfrom
mokagio/add-changelog
Oct 20, 2022
Merged

Add CHANGELOG.md#396
mokagio merged 5 commits intotrunkfrom
mokagio/add-changelog

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Oct 19, 2022

Adds CHANGELOG.md. Based on wordpress-mobile/WordPressKit-iOS#545 and the PR template iteration from wordpress-mobile/WordPressUI-iOS#119.

@mokagio mokagio enabled auto-merge October 19, 2022 18:44
@mokagio mokagio requested a review from a team October 19, 2022 18:45
@AliSoftware
Copy link
Contributor

@mokagio CI is failing due to that default bundle issue. You'll probably need to update the bash-cache-buildkite-plugin while you're at it (like you did on the similar PRs of some of the other repos).

@crazytonyli
Copy link
Contributor

Will there be any issue if the old change logs are kept? Is it cause some kind of parsing issue?

@mokagio
Copy link
Contributor Author

mokagio commented Oct 20, 2022

@crazytonyli ouch! I didn't notice that 🤦‍♂️

I'll revert the change so that the previous changes are maintained.

As for whether the different format will result in parsing issues... maybe? We don't have an official or portable parser at the moment. The closest thing is the one used in release-toolkit. I think that one would not work because it expect "Trunk" where this has "Unreleased".

I guess we'll address this scenario once we'll get to automate extracting the release notes in all the pods?

@crazytonyli
Copy link
Contributor

@mokagio All good. I thought they were deleted intentionally 😸

@mokagio mokagio merged commit 1556d10 into trunk Oct 20, 2022
@mokagio mokagio deleted the mokagio/add-changelog branch October 20, 2022 07:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants