Skip to content

Merge final release/20.6#17118

Merged
AliSoftware merged 5 commits intotrunkfrom
release/20.6
Sep 3, 2022
Merged

Merge final release/20.6#17118
AliSoftware merged 5 commits intotrunkfrom
release/20.6

Conversation

@AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Sep 2, 2022

  • changelog/*.txt files updated with latest translations
  • A lot of PlayStore metadata (especially full_description.txt) updated now that the polyglots came up with a translation for the new copy that fits the 4000 character limit 🎉
  • values*/strings.xml updated with latest translations
  • Version bumped in version.properties
  • WPAndroid submitted to Google for review
  • JPAndroid submitted to Google for review

@AliSoftware AliSoftware added the Releases Label related to managing releases label Sep 2, 2022
@AliSoftware AliSoftware added this to the 20.7 milestone Sep 2, 2022
@AliSoftware AliSoftware self-assigned this Sep 2, 2022
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 2, 2022

You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr17118-c43e5ed.apk), or scanning this QR code:

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Sep 2, 2022

You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr17118-c43e5ed.apk), or scanning this QR code:

Copy link
Contributor Author

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 While submitting the WordPress build, I (almost missed but) noticed that the <en-US> entry for the release notes on the Play Store Console submission page… was empty, so the app almost didn't get English Release Notes submitted to Google 😱

Indeed, when you look at the diff in this PR, you can see that while for Jetpack in fastlane/jetpack_metadata/android/en-US/changelogs/, 1262.txt got deleted and 1266.txt got added instead, but for WordPress in fastlane/metadata/android/en-US/changelogs/, 1262.txt got deleted without a new 1266.txt file being created.

My theory is that this is because en-gb didn't get a translation for release notes in GlotPress this time around, and since we treat en-US using a dirty trick for WP by downloading en-gb and mapping it to en-US, the fact that the key was not translated for en-gb lead to it not being part of the current set when downloaded from GlotPress, and the hack thus wasn't able to extract the source from that.

This is yet another reason why this ugly hack with the source_locale and { 'en-gb' => 'en-US' } should disappear and be refactored (ref: pdnsEh-jJ-p2), to avoid not only the ugliness and hard to read logic/config at call site, but also to avoid such bugs in the future.


In the meantime, despite that fastlane/metadata/android/en-US/changelogs/1266.txt not being present in this PR, I've manually copy/pasted the English copy of the release notes inside the <en-US> tag in the Play Store Console before submitting for review.

יצירה

לרעיונות הנהדרים שלך מגיעה פינה חמה באינטרנט. אפליקציית Jetpack ל-Android מאפשרת לך לבנות אתרים וליצור בלוגים על התשתית של WordPress. כדאי להשתמש בה ליצירת האתר שלך.
לרעיונות הנהדרים שלך מגיעה פינה חמה באינטרנט. אפליקציית Jetpack ל-Android מאפשרת לך ליצור אתרים ובלוגים על תשתית של WordPress. כדאי להשתמש בה ליצירת האתר שלך.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to have been taken into account by PlayStore:
image

@@ -0,0 +1 @@
Bygg en WordPress-webbplats, skapa inlägg, lägg till foton och se statistik!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed to have been taken into account by PlayStore:
image

@@ -1,45 +1,40 @@
يضع تطبيق ووردبريس لنظام التشغيل Android قوة النشر على الويب في متناولك. إنَّه مُنشئ موقع على الويب وأكثر من ذلك بكثير!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submission to PlayStore Console confirmed that this and all the other fastlane/metadata/android/*/full_description.txt for other locales have been taken into account:
PlayStore-20 6

Copy link
Contributor Author

@AliSoftware AliSoftware Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! That made me realize that "English — en-US" was not part of that list 😱 — same bug as for the release notes above I guess ➡️ Follow up below

@AliSoftware
Copy link
Contributor Author

AliSoftware commented Sep 2, 2022

While submitting the WordPress build, I (almost missed but) noticed that the <en-US> entry for the release notes on the Play Store Console submission page… was empty, so the app almost didn't get English Release Notes submitted to Google 😱

Actually the exact same issue happened for the en-US for new "Play Store Description" (which I also almost failed to notice). So I ended up:

  • Submitting the translations for play_store_desc and release_note_206 for en-gb in GlotPress, by just using the same copy as the original en-US
  • Then re-running bundle exec fastlane download_wordpress_metadata_strings version:20.6 build_number:1266, which got those files for en-US back — incidentally confirming my suspicion that this was the cause of the bug

Which pushed a second Update WordPress metadata translations for 20.6 commit c43e5ed after all to fix the issue.

Still had to manually copy/paste the description to Play Store Console too (I guess I could have re-run supply but was faster to do manual pasting)

@AliSoftware AliSoftware requested a review from a team September 2, 2022 17:20
Copy link
Contributor

@oguzkocer oguzkocer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AliSoftware I am sorry you had to deal with all these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Releases Label related to managing releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants