Conversation
|
You can test the WordPress changes on this Pull Request by downloading an installable build (wordpress-installable-build-pr17118-c43e5ed.apk), or scanning this QR code: |
|
You can test the Jetpack changes on this Pull Request by downloading an installable build (jetpack-installable-build-pr17118-c43e5ed.apk), or scanning this QR code: |
AliSoftware
left a comment
There was a problem hiding this comment.
😱 While submitting the WordPress build, I (almost missed but) noticed that the <en-US> entry for the release notes on the Play Store Console submission page… was empty, so the app almost didn't get English Release Notes submitted to Google 😱
Indeed, when you look at the diff in this PR, you can see that while for Jetpack in fastlane/jetpack_metadata/android/en-US/changelogs/, 1262.txt got deleted and 1266.txt got added instead, but for WordPress in fastlane/metadata/android/en-US/changelogs/, 1262.txt got deleted without a new 1266.txt file being created.
My theory is that this is because en-gb didn't get a translation for release notes in GlotPress this time around, and since we treat en-US using a dirty trick for WP by downloading en-gb and mapping it to en-US, the fact that the key was not translated for en-gb lead to it not being part of the current set when downloaded from GlotPress, and the hack thus wasn't able to extract the source from that.
This is yet another reason why this ugly hack with the source_locale and { 'en-gb' => 'en-US' } should disappear and be refactored (ref: pdnsEh-jJ-p2), to avoid not only the ugliness and hard to read logic/config at call site, but also to avoid such bugs in the future.
In the meantime, despite that fastlane/metadata/android/en-US/changelogs/1266.txt not being present in this PR, I've manually copy/pasted the English copy of the release notes inside the <en-US> tag in the Play Store Console before submitting for review.
| יצירה | ||
|
|
||
| לרעיונות הנהדרים שלך מגיעה פינה חמה באינטרנט. אפליקציית Jetpack ל-Android מאפשרת לך לבנות אתרים וליצור בלוגים על התשתית של WordPress. כדאי להשתמש בה ליצירת האתר שלך. | ||
| לרעיונות הנהדרים שלך מגיעה פינה חמה באינטרנט. אפליקציית Jetpack ל-Android מאפשרת לך ליצור אתרים ובלוגים על תשתית של WordPress. כדאי להשתמש בה ליצירת האתר שלך. |
| @@ -0,0 +1 @@ | |||
| Bygg en WordPress-webbplats, skapa inlägg, lägg till foton och se statistik! | |||
| @@ -1,45 +1,40 @@ | |||
| يضع تطبيق ووردبريس لنظام التشغيل Android قوة النشر على الويب في متناولك. إنَّه مُنشئ موقع على الويب وأكثر من ذلك بكثير! | |||
There was a problem hiding this comment.
Ah! That made me realize that "English — en-US" was not part of that list 😱 — same bug as for the release notes above I guess ➡️ Follow up below
Actually the exact same issue happened for the
Which pushed a second Still had to manually copy/paste the description to Play Store Console too (I guess I could have re-run |
oguzkocer
left a comment
There was a problem hiding this comment.
@AliSoftware I am sorry you had to deal with all these issues.



changelog/*.txtfiles updated with latest translationsfull_description.txt) updated now that the polyglots came up with a translation for the new copy that fits the 4000 character limit 🎉values*/strings.xmlupdated with latest translationsversion.properties