Stories Additional Code Removals

[antonis]

Additional code removal suggestions on top of #20016

---

To Test:

See #20016

---

Regression Notes

1. Potential unintended areas of impact

   • N/A

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • N/A

3. What automated tests I added (or what prevented me from doing so)

   • N/A

---

PR Submission Checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

Testing Checklist:

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[dangermattic]

	3 Warnings
⚠️	strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20341-a6801a9
	Commit	a6801a9
	Direct Download	wordpress-prototype-build-pr20341-a6801a9.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20341-a6801a9
	Commit	a6801a9
	Direct Download	jetpack-prototype-build-pr20341-a6801a9.apk

Note: Google Login is not supported on these builds.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 40.48%. Comparing base (0ad2125) to head (a6801a9).

Files	Patch %	Lines
...g/wordpress/android/ui/mysite/menu/MenuActivity.kt	0.00%	1 Missing ⚠️

Additional details and impacted files

@@                  Coverage Diff                   @@
##           issue/stories-removal   #20341   +/-   ##
======================================================
  Coverage                  40.48%   40.48%           
======================================================
  Files                       1458     1458           
  Lines                      66996    66988    -8     
  Branches                   11105    11104    -1     
======================================================
- Hits                       27124    27122    -2     
+ Misses                     37391    37386    -5     
+ Partials                    2481     2480    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[antonis]

I think any random icon would fit the purposes of the preview

[antonis]

As above https://github.com/wordpress-mobile/WordPress-Android/pull/20341/files#r1508694602

[jarvislin]

Thank you for listing so many pieces of related code that I hadn't noticed. It looks fantastic.