Merged
Conversation
14 tasks
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21575-96eb856 | |
| Commit | 96eb856 | |
| Direct Download | wordpress-prototype-build-pr21575-96eb856.apk |
Contributor
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21575-96eb856 | |
| Commit | 96eb856 | |
| Direct Download | jetpack-prototype-build-pr21575-96eb856.apk |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21575 +/- ##
=======================================
Coverage 39.48% 39.48%
=======================================
Files 2117 2117
Lines 99464 99464
Branches 15296 15296
=======================================
Hits 39269 39269
Misses 56714 56714
Partials 3481 3481 ☔ View full report in Codecov by Sentry. |
dcalhoun
approved these changes
Jan 10, 2025
Member
dcalhoun
left a comment
There was a problem hiding this comment.
Always feels great to delete code. 🔥
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Fixes #21574
As noted on this iOS PR, the Jetpack "Lazy images" setting has been removed from the backend, but we continued to show it in the apps.
This PR addresses this by removing this setting, and also adjusts the Site Accelerator screen to make more visual sense. Note that there's more to do here - our Jetpack settings are a bit of a mess - but this is a step in the right direction.
To test:
BEFORE
AFTER