Skip to content

feat: GutenbergKit internationalization#21854

Merged
dcalhoun merged 9 commits intotrunkfrom
feat/gutenberg-kit-internationalization
May 12, 2025
Merged

feat: GutenbergKit internationalization#21854
dcalhoun merged 9 commits intotrunkfrom
feat/gutenberg-kit-internationalization

Conversation

@dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented May 2, 2025

Description

Ref CMM-280. Provide GutenbergKit with the current locale so that localization may occur.

Testing instructions

See wordpress-mobile/GutenbergKit#120.

@dcalhoun dcalhoun added [Type] Enhancement i18n Gutenberg Editing and display of Gutenberg blocks. labels May 2, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented May 2, 2025

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 2, 2025

Project dependencies changes

list
! Upgraded Dependencies
org.wordpress.gutenbergkit:android:trunk-fdfe788530bbff864ce7147b5a68608d7025e078, (changed from v0.2.0)
tree
 +--- project :libs:editor
-|    \--- org.wordpress.gutenbergkit:android:v0.2.0
+|    \--- org.wordpress.gutenbergkit:android:trunk-fdfe788530bbff864ce7147b5a68608d7025e078
-\--- org.wordpress.gutenbergkit:android:v0.2.0 (*)
+\--- org.wordpress.gutenbergkit:android:trunk-fdfe788530bbff864ce7147b5a68608d7025e078 (*)

@dcalhoun dcalhoun force-pushed the feat/gutenberg-kit-internationalization branch from 1a79551 to b238c9e Compare May 2, 2025 15:14
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 2, 2025

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21854-516768b
Commit516768b
Direct Downloadjetpack-prototype-build-pr21854-516768b.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 2, 2025

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21854-516768b
Commit516768b
Direct Downloadwordpress-prototype-build-pr21854-516768b.apk
Note: Google Login is not supported on these builds.

@codecov
Copy link

codecov bot commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.38%. Comparing base (d9160f3) to head (eeb28f7).
Report is 2 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21854   +/-   ##
=======================================
  Coverage   39.38%   39.38%           
=======================================
  Files        2134     2134           
  Lines      100053   100053           
  Branches    15408    15408           
=======================================
  Hits        39406    39406           
  Misses      57164    57164           
  Partials     3483     3483           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcalhoun dcalhoun force-pushed the feat/gutenberg-kit-internationalization branch from a833661 to 8ba3847 Compare May 8, 2025 19:57
@dcalhoun dcalhoun force-pushed the feat/gutenberg-kit-internationalization branch from 8ba3847 to 0f73c3c Compare May 9, 2025 14:14
@dcalhoun dcalhoun marked this pull request as ready for review May 9, 2025 21:07
@dcalhoun dcalhoun requested a review from a team as a code owner May 9, 2025 21:07
@dcalhoun dcalhoun requested review from nbradbury and removed request for a team May 9, 2025 21:07
@nbradbury nbradbury self-assigned this May 12, 2025
Copy link
Contributor

@nbradbury nbradbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tested fine, merge when ready :shipit:

@dcalhoun dcalhoun enabled auto-merge (squash) May 12, 2025 20:54
@sonarqubecloud
Copy link

@dcalhoun dcalhoun merged commit 581d152 into trunk May 12, 2025
24 of 26 checks passed
@dcalhoun dcalhoun deleted the feat/gutenberg-kit-internationalization branch May 12, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks. i18n [Type] Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants