RS Post Settings: Performance improvements by nbradbury · Pull Request #22685 · wordpress-mobile/WordPress-Android

nbradbury · 2026-03-12T17:44:59Z

Description

On self-hosted sites, a new WpApiClient was created for every API call — 5 client instantiations just to open the settings screen (1 post fetch + 4 async field resolutions). Now WpApiClientProvider caches self-hosted clients the same way it already caches WP.com clients, and the ViewModel reuses a single lazy client. This reduces self-hosted load time from 5 client creations to 1.

This PR also adds a shimmer effect when loading post settings, improving upon the simple progress spinner we used previously.

Testing instructions

Run trunk with a content-heavy self-hosted site (provided via DM)

Verify RS post settings load slowly

Run this branch with the same site

Verify RS post settings load noticeably faster than before
Verify a shimmer effect appears while loading

content-heavy.mp4

Replace Toast with Compose Snackbar for inline error messages with retry actions, add pull-to-refresh support, show "Saving..." label alongside the spinner, display "Not Set" placeholder for empty status, and improve accessibility with content descriptions for password toggle and featured image placeholder. Extract shared error utilities from PostRsListViewModel into PostRsErrorUtils for reuse across both list and settings screens. Add unit tests for PostRsSettingsViewModel. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Preserve unsaved edits when refreshing post from server - Remove unreachable snackbar when site is null (activity finishes immediately) - Fix PullToRefreshBox content indentation - Remove redundant offline mocks in refresh tests - Rename misleading test name for status selection - Add test for save-online sets isSaving Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Extract preserveEdits() helper to shorten refreshPost() below the 60-line detekt limit, and remove empty line after opening brace in test class. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add navigationBarsPadding to SnackbarHost so snackbars aren't obscured by the system navigation bar. Wrap ErrorContent in a centered Box so the error message displays in the center of the screen instead of at the top. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Add fillMaxWidth and TextAlign.Center to the ErrorContent on the term selection screen so the network error message is properly centered horizontally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

The network error snackbar shown when saving in airplane mode was missing an actionLabel and onAction callback, so no Retry button appeared. Add both so the user can retry saving after reconnecting. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Set the snackbar action color to MaterialTheme.colorScheme.primary so the Retry text on snackbars matches the primary color used by the Retry button on the error empty state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

…race condition When disabling airplane mode and immediately tapping Retry, Android may not have re-established connectivity yet, causing a spurious network error. Now the save always proceeds to the API call, which handles network errors naturally via its catch block using PostRsErrorUtils.friendlyErrorMessage(). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Use BackHandler(onBack=) instead of wrapping lambda - Use ?.let { } ?: Modifier for conditional click modifiers - Replace PostApiException with RuntimeException - Inline isAuthError wrapper in PostRsListViewModel - Remove status bar hiding to fix PTR triggering on system bar pull Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Replace RuntimeException with PostApiRequestException to fix TooGenericExceptionThrown detekt violations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

On self-hosted sites, a new WpApiClient was created for every API call (5 instantiations just to open post settings). Cache self-hosted clients in WpApiClientProvider (mirroring the existing WP.com pattern), add a per-site client cache in PostRsRestClient, and use a lazy property in PostRsSettingsViewModel to reuse the same client across fetch and save. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Now that WpApiClientProvider caches self-hosted clients, the per-site client cache in PostRsRestClient is redundant — remove it. Also remove the now-unused site parameters from fetchPost() and savePost() in the ViewModel, and replace shadowed locals with simple null guards. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

dangermattic · 2026-03-12T17:45:41Z

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

…eption, remove unused methods Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

wpmobilebot · 2026-03-12T18:29:55Z

📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Android
	Build Type	Debug
	Version	pr22685-7b8bd14
	Build Number	`1487`
	Application ID	`com.jetpack.android.prealpha`
	Commit	`7b8bd14`
	Installation URL	6cqv3pb3e76c0

Note: Google Login is not supported on these builds.

wpmobilebot · 2026-03-12T18:31:34Z

📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

	App Name	WordPress Android
	Build Type	Debug
	Version	pr22685-7b8bd14
	Build Number	`1487`
	Application ID	`org.wordpress.android.prealpha`
	Commit	`7b8bd14`
	Installation URL	4dkdmtrgc8auo

Note: Google Login is not supported on these builds.

codecov · 2026-03-12T18:37:05Z

Codecov Report

❌ Patch coverage is 2.32558% with 84 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.61%. Comparing base (6ad0a42) to head (7b8bd14).
⚠️ Report is 1 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...android/ui/postsrs/screens/PostRsSettingsScreen.kt	0.00%	54 Missing ⚠️
...fluxc/network/rest/wpapi/rs/WpApiClientProvider.kt	0.00%	19 Missing ⚠️
...ress/android/ui/postsrs/PostRsSettingsViewModel.kt	15.38%	9 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #22685      +/-   ##
==========================================
- Coverage   37.63%   37.61%   -0.02%     
==========================================
  Files        2272     2272              
  Lines      118333   118378      +45     
  Branches    16363    16369       +6     
==========================================
+ Hits        44530    44531       +1     
- Misses      70150    70195      +45     
+ Partials     3653     3652       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Show hero image shimmer and placeholder rows while loading instead of a titled app bar with a centered spinner. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Extract shared HeroOverlay composable to deduplicate gradient and back button between loading skeleton and hero layout - Inline statusResId variable - Remove unreachable site null guards in ViewModel - Remove extra blank line in WpApiClientProvider Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

adalpari

Edited: Sorry, Claude posted itself in my name here without my permission...

adalpari · 2026-03-16T10:48:17Z

I found Claude finding some point that are worth to have a look at them. If you think they are false positives, just let me know.

Thread safety concern in WpApiClientProvider

getWpApiClient is @synchronized, but clearWpComClients only synchronizes on itself and only clears wpComClients. If self-hosted clients should also be cleared on sign-out (e.g.
switching accounts), there's no clearSelfHostedClients equivalent. Worth considering whether stale self-hosted clients could persist across account changes.

apiClient laziness vs. null site

In the ViewModel, apiClient is a lazy property:
private val apiClient by lazy {
site?.let { wpApiClientProvider.getWpApiClient(it) }
}
If site is null, apiClient will be permanently null (lazy evaluates once). The old code had early val site = site ?: return guards in each method. Now those guards are removed
from loadPost(), refreshPost(), and onSaveClicked(), meaning if site is null, execution continues until it hits ?: throw PostApiRequestException("No API client") — which may be
fine, but the error message "No API client" is less descriptive than a clear "no site selected" scenario. Consider whether a null site should fail earlier and with a clearer
message.

Inconsistent null handling pattern

fetchPost() and savePost() throw PostApiRequestException("No API client") when apiClient is null, but loadPost() and refreshPost() removed their site ?: return guards without
adding equivalent protection. The network check will still run, and the coroutine will launch before hitting the null client. This is functionally okay but slightly wasteful —
the old pattern of returning early was marginally cleaner.

Clear self-hosted client cache on sign-out to prevent stale credentials, remove double background in ShimmerRow so the animated shimmer renders correctly, and restore early-return guards for null apiClient in ViewModel. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

nbradbury · 2026-03-16T12:51:36Z

I found Claude finding some point that are worth to have a look at them. If you think they are false positives, just let me know.

I fixed all three of those issues. I also fixed a shimmer issue that a fresh local /review uncovered.

Check `site == null` instead of `apiClient == null` to avoid triggering unnecessary lazy evaluation and to match the original guard pattern the code previously used. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

sonarqubecloud · 2026-03-16T13:05:12Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adalpari · 2026-03-16T13:49:26Z

Unfortunately, I'm seeing an error when trying to load the posts list.

2026-03-16 14:47:16.012 28216-28216 WordPress-POSTS com.jetpack.android.prealpha E Failed to init RS post list tab (Fix with AI)
uniffi.wp_mobile_cache.SqliteDbException$SqliteException: v1=Invalid parameter name: next migration index (12) exceeds available migrations (11)
at uniffi.wp_mobile_cache.FfiConverterTypeSqliteDbError.read(wp_mobile_cache.kt:2253)
at uniffi.wp_mobile_cache.FfiConverterTypeSqliteDbError.read(wp_mobile_cache.kt:2248)
at uniffi.wp_mobile_cache.FfiConverter$DefaultImpls.liftFromRustBuffer(wp_mobile_cache.kt:161)
at uniffi.wp_mobile_cache.FfiConverterRustBuffer$DefaultImpls.liftFromRustBuffer(wp_mobile_cache.kt:177)
at uniffi.wp_mobile_cache.FfiConverterTypeSqliteDbError.liftFromRustBuffer(wp_mobile_cache.kt:2248)
at uniffi.wp_mobile_cache.FfiConverterTypeSqliteDbError.liftFromRustBuffer(wp_mobile_cache.kt:2248)
at uniffi.wp_mobile_cache.FfiConverterRustBuffer$DefaultImpls.lift(wp_mobile_cache.kt:178)
at uniffi.wp_mobile_cache.FfiConverterTypeSqliteDbError.lift(wp_mobile_cache.kt:2248)
at uniffi.wp_mobile_cache.FfiConverterTypeSqliteDbError.lift(wp_mobile_cache.kt:2248)
at uniffi.wp_mobile_cache.SqliteDbException$ErrorHandler.lift(wp_mobile_cache.kt:2239)
at uniffi.wp_mobile_cache.SqliteDbException$ErrorHandler.lift(wp_mobile_cache.kt:2238)
at uniffi.wp_mobile_cache.Wp_mobile_cacheKt.uniffiCheckCallStatus(wp_mobile_cache.kt:245)
at uniffi.wp_mobile_cache.Wp_mobile_cacheKt.access$uniffiCheckCallStatus(wp_mobile_cache.kt:1)
at uniffi.wp_mobile_cache.WpApiCache.performMigrations(wp_mobile_cache.kt:2392)
at rs.wordpress.cache.kotlin.WordPressApiCache.performMigrations(WordPressApiCache.kt:24)
at org.wordpress.android.ui.postsrs.data.WpServiceProvider.getOrCreateCache(WpServiceProvider.kt:94)
at org.wordpress.android.ui.postsrs.data.WpServiceProvider.createService(WpServiceProvider.kt:51)
at org.wordpress.android.ui.postsrs.data.WpServiceProvider.getService(WpServiceProvider.kt:40)
at org.wordpress.android.ui.postsrs.PostRsListViewModel$createCollection$2.invokeSuspend(PostRsListViewModel.kt:558)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:34)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:100)
at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:124)
at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:586)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:820)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:717)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:704)

nbradbury · 2026-03-16T14:13:38Z

Unfortunately, I'm seeing an error when trying to load the posts list.

Hmm, I'm not seeing this with any of my sites. Perhaps you need to sync with Gradle since earlier you were working with a wp-rs update?

adalpari · 2026-03-16T14:58:39Z

Unfortunately, I'm seeing an error when trying to load the posts list.

Hmm, I'm not seeing this with any of my sites. Perhaps you need to sync with Gradle since earlier you were working with a wp-rs update?

A fresh install worked. So, yes probably a cache issue 🤷‍♂️

adalpari

nbradbury and others added 12 commits March 12, 2026 06:58

RS Post Settings: Fix detekt and checkstyle issues

13ed3a1

Extract preserveEdits() helper to shorten refreshPost() below the 60-line detekt limit, and remove empty line after opening brace in test class. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

RS Post Settings: Center error content on term selection screen

8f71432

Add fillMaxWidth and TextAlign.Center to the ErrorContent on the term selection screen so the network error message is properly centered horizontally. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

RS Post Settings: Use named exception to satisfy detekt

d927a7c

Replace RuntimeException with PostApiRequestException to fix TooGenericExceptionThrown detekt violations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

nbradbury added the unit-tests-exemption label Mar 12, 2026

nbradbury added Posts + Pages Performance Post Settings labels Mar 12, 2026

nbradbury changed the base branch from trunk to feature/rsposts-settings-polish March 12, 2026 17:48

nbradbury changed the title ~~RS Post Settings: Performance and polish improvements~~ RS Post Settings: Performance improvements Mar 12, 2026

nbradbury and others added 2 commits March 12, 2026 13:59

RS Post Settings: Fix import ordering, replace crash with handled exc…

71c07f1

…eption, remove unused methods Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

RS Post Settings: Fix detekt ThrowsCount and ReturnCount violations

54dd368

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

nbradbury requested review from adalpari and removed request for adalpari March 12, 2026 21:08

Base automatically changed from feature/rsposts-settings-polish to trunk March 13, 2026 11:14

nbradbury and others added 3 commits March 13, 2026 07:28

Merge trunk into feature/rsposts-settings-performance

0ff0162

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

RS Post Settings: Replace loading spinner with shimmer skeleton

5fb0844

Show hero image shimmer and placeholder rows while loading instead of a titled app bar with a centered spinner. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

nbradbury marked this pull request as ready for review March 13, 2026 13:06

nbradbury requested a review from adalpari March 13, 2026 13:06

adalpari reviewed Mar 16, 2026

View reviewed changes

RS Post Settings: Use site null check instead of apiClient

7b8bd14

Check `site == null` instead of `apiClient == null` to avoid triggering unnecessary lazy evaluation and to match the original guard pattern the code previously used. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

adalpari approved these changes Mar 16, 2026

View reviewed changes

nbradbury merged commit 0fb8526 into trunk Mar 16, 2026
24 checks passed

nbradbury deleted the feature/rsposts-settings-performance branch March 16, 2026 14:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RS Post Settings: Performance improvements#22685

RS Post Settings: Performance improvements#22685
nbradbury merged 19 commits intotrunkfrom
feature/rsposts-settings-performance

nbradbury commented Mar 12, 2026 •

edited

Loading

Uh oh!

dangermattic commented Mar 12, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Mar 12, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Mar 12, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 12, 2026 •

edited

Loading

Uh oh!

adalpari left a comment •

edited

Loading

Uh oh!

adalpari commented Mar 16, 2026

Uh oh!

nbradbury commented Mar 16, 2026

Uh oh!

sonarqubecloud bot commented Mar 16, 2026

Uh oh!

adalpari commented Mar 16, 2026

Uh oh!

nbradbury commented Mar 16, 2026

Uh oh!

adalpari commented Mar 16, 2026

Uh oh!

adalpari left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nbradbury commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

dangermattic commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

adalpari left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adalpari commented Mar 16, 2026

Uh oh!

nbradbury commented Mar 16, 2026

Uh oh!

sonarqubecloud bot commented Mar 16, 2026

Quality Gate passed

Uh oh!

adalpari commented Mar 16, 2026

Uh oh!

nbradbury commented Mar 16, 2026

Uh oh!

adalpari commented Mar 16, 2026

Uh oh!

adalpari left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nbradbury commented Mar 12, 2026 •

edited

Loading

dangermattic commented Mar 12, 2026 •

edited

Loading

wpmobilebot commented Mar 12, 2026 •

edited

Loading

wpmobilebot commented Mar 12, 2026 •

edited

Loading

codecov bot commented Mar 12, 2026 •

edited

Loading

adalpari left a comment •

edited

Loading