Skip to content

Update Helpshift from 3.12 to 4.1.1-support#3451

Merged
kwonye merged 3 commits intodevelopfrom
issue/helpshift-4.x-update
Jan 8, 2016
Merged

Update Helpshift from 3.12 to 4.1.1-support#3451
kwonye merged 3 commits intodevelopfrom
issue/helpshift-4.x-update

Conversation

@maxme
Copy link
Copy Markdown
Contributor

@maxme maxme commented Nov 27, 2015

No description provided.

@maxme
Copy link
Copy Markdown
Contributor Author

maxme commented Nov 27, 2015

Just noticed there is a bug with the new Helpshift version, can't attach pictures to support message.

@maxme
Copy link
Copy Markdown
Contributor Author

maxme commented Dec 1, 2015

Note: Helpshift support contacted

@kwonye
Copy link
Copy Markdown
Contributor

kwonye commented Dec 13, 2015

Does the latest com.helpshift:android-aar:4.2.0-support fix this? https://developers.helpshift.com/android/release-notes/

@maxme
Copy link
Copy Markdown
Contributor Author

maxme commented Dec 14, 2015

Does the latest com.helpshift:android-aar:4.2.0-support fix this?

No

@maxme
Copy link
Copy Markdown
Contributor Author

maxme commented Jan 7, 2016

HelpShift crashes are now #2 in our top 10, just after the Samsung bug. So, I think we should update to 4.2.0 even with that upload issue.

@maxme maxme added this to the 5.0 milestone Jan 7, 2016
@tonyr59h tonyr59h self-assigned this Jan 7, 2016
@kwonye
Copy link
Copy Markdown
Contributor

kwonye commented Jan 7, 2016

@maxme the crashes seem to only be photos that are not in local storage. I was able to upload a screenshot fine and so was @amylaneio. I think this is good enough for us.

If you agree, feel free to :shipit: anytime you like.

@tonyr59h tonyr59h assigned kwonye and unassigned tonyr59h Jan 7, 2016
@maxme
Copy link
Copy Markdown
Contributor Author

maxme commented Jan 8, 2016

If you agree, feel free to anytime you like.

👍 Let's merge it.

@kwonye
Copy link
Copy Markdown
Contributor

kwonye commented Jan 8, 2016

Thanks for keeping our dependencies updated!

kwonye added a commit that referenced this pull request Jan 8, 2016
@kwonye
Merge pull request #3451 from wordpress-mobile/issue/helpshift-4.x-up…
fe4e094 
…date

Update Helpshift from 3.12 to 4.1.1-support
@kwonye kwonye merged commit fe4e094 into develop Jan 8, 2016
@kwonye kwonye deleted the issue/helpshift-4.x-update branch January 8, 2016 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kwonye kwonye

Labels

None yet

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@maxme @kwonye @tonyr59h