Feature/reader search results#4094
Closed
nbradbury wants to merge 48 commits intofeature/reader-search-masterfrom
Closed
Feature/reader search results#4094nbradbury wants to merge 48 commits intofeature/reader-search-masterfrom
nbradbury wants to merge 48 commits intofeature/reader-search-masterfrom
Conversation
…ss-Android into feature/reader-search-results
…ss-Android into feature/reader-search-results
…ground-app-state Properly detect when the app goes to the background
…ss-Android into feature/reader-search-results
Contributor
Author
|
Something got messed up in this pull request - it's showing commits that aren't part of this. Closing and resubmitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expands upon #4085 by querying the backend for search results and showing them within the main reader list (ie: within the "masterbar" reader). Changes include:
read/searchendpoint to search for postsReaderSearchServiceto perform the searchThis PR turned out to be considerably larger than I anticipated, so if any non-trivial issues are found I may move them to a separate PR to avoid inflating this one further.
Note that the design & wording still aren't final - a design review will occur at a later date, and this can be merged into the feature branch prior to that review.
Update: I meant to mention that I've seen some weird behavior with
SearchViewon Android emulators, so I recommend using a real device to test this.