Site creation rework: Offer a "Close" button on failure after creation#7224
Closed
hypest wants to merge 1 commit intofeature/new-signupfrom
Closed
Site creation rework: Offer a "Close" button on failure after creation#7224hypest wants to merge 1 commit intofeature/new-signupfrom
hypest wants to merge 1 commit intofeature/new-signupfrom
Conversation
13 tasks
theck13
suggested changes
Feb 20, 2018
Contributor
theck13
left a comment
There was a problem hiding this comment.
Everything looks good, but there are a few conflicts to resolve before merging.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7221
Shows a "Close" button when the site-creation process finishes but the new site has been created remotely. If it hasn't, a "Back" button is displayed.
To test #1:
To test #2: