Aztec - Log NumberFormatException in CleaningUtils#9535
Merged
jtreanor merged 1 commit intorelease/12.1from Apr 8, 2019
Merged
Conversation
…se of crashes durint Aztec init --> cleaning utils
mzorz
approved these changes
Apr 8, 2019
Contributor
mzorz
left a comment
mzorz
left a comment
There was a problem hiding this comment.
Code looks good, unfortunately can't test it where I am now but I'm sure it won't cause harm (and will hopefully give us information to continue tracking down the issue) so, let's merge
LGTM 
jtreanor
approved these changes
Apr 8, 2019
Contributor
jtreanor
left a comment
jtreanor
left a comment
There was a problem hiding this comment.
This also looks good to me 👌
oguzkocer
deleted the
issue/805-Take-2-Aztec-NumberFormatException-in-CleaningUtils
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think i've found a quick way to log the content of the editor (when privacy conditions are met) in case of this weird crash happening in clean utils of Aztec - wordpress-mobile/AztecEditor-Android#805
(This time with the correct base branch!)
Update release notes:
[ x ] If there are user facing changes, I have added an item to RELEASE-NOTES.txt.