NSInvalidArgumentException: -[__NSCFSet addObject:]: attempt to insert nil

[sentry]

Context

p1686492647752149-slack-C0180B5PRJ4

Sentry Information

Sentry Issue: JETPACK-IOS-31 and this specific Sentry event:

NSInvalidArgumentException: -[__NSCFSet addObject:]: attempt to insert nil
  File "main.swift", line 7, in main
...
(12 additional frame(s) were not displayed)

[guarani]

Related Issues

This Sentry issue contains seemingly quite different crashes under the umbrella.

Core Data related

Core Data issues look to be more critical and frequent since 22.3

• Core Data: Multithreading violation when setting blogging reminders #20841
• Core Data: Multithreading violation when retrieving reminder information #20842
• Core Data: crash triggered from NullBlogPropertySanitizer #20847

UI Related

Nested under the same Sentry issue but could be unrelated

• Stats: 'Can't add self as subview' crash #20849
• Reader: 'Can't add self as subview' crash when closing the Reader #20843

I removed the above section now that all these issues are on this GitHub board: https://github.com/orgs/wordpress-mobile/projects/194

I've temporarily assigned myself this issue while I download iOS 17 beta and test there following this lead at the crash occurred on iOS 17 beta.

[guarani]

Turns out this crash happens on iOS 16, too: https://a8c.sentry.io/issues/3140539221/events/?project=5716771&query=os%3A%22iOS+16.%2A%22+message%3A%22attempt+to+insert+nil%22&referrer=github_integration

Thanks @salimbraksa for pointing this out.

[staskus]

Update

Crashes with a stack trace of NSInvalidArgumentException: -[__NSCFSet addObject:]: attempt to insert nil have decreased significantly.

• 261 occurrences in 22.3
• 253 occurrences in 22.4
• 108 occurrences in 22.5
• 3 occurrences in 22.6
• 3 occurrences in 22.7

[mokagio]

Here's an alternative query that produces a visualization with basically the same results.

[sentry]

Sentry issue: JETPACK-IOS-31

[sentry]

Sentry issue: JETPACK-IOS-FC4