Fix a number of push notification issues#1000
Conversation
…dle notification if active When a background push launches the app (which it can do in iOS 7) the notification was being handled twice. Ensure that the app is in an active state when attempting to handle a notification sent through to the didFinishLaunching.
|
4 - it's being called on logout in 22-accounts I believe. 1 - the background pushes were updating the UI to use iOS7's multitasking features. When the completion handler is called, a screenshot is taken of the current state. Granted, you may not be on the notifications screen :) Perhaps if you are, we should update the UI? |
|
@xtreme-rebecca-putinski I reversed the change made to the WordPress.com API for unregistering notifications. Yeah I think I'm going to put the Notifications screen UI changes into another ticket, because some cleanup is going to be needed. Hooking into the will/did/Appear/Disappear is hokey especially with the background updates. |
There was a problem hiding this comment.
@astralbodies - Did you mean to get rid of the mixpanel call as well?
There was a problem hiding this comment.
I removed it since this is fired off and has no user interaction (app didn't actually open)
There was a problem hiding this comment.
Ahhh - can we move it to someplace where the user does have interaction - i.e. https://github.com/wordpress-mobile/WordPress-iOS/pull/1000/files#diff-12c33a973ac67adb445a57af0d26b92cR128?
There was a problem hiding this comment.
@sendhil It is being handled in this method - sorry it took me forever to verify 😄
Fix a number of push notification issues
Fixes #961
Still can't reproduce the problem with credentials being lost on the device after a background push was received. Discovered a number of problems with push, however, and have resolved them in this PR.