Move flags icon to main project.

[jklausa]

Fixes #11361.

This moves (well, copies.) all the flags images back to the main app.

Long-term goal is to get rid of WPStatsiOS framework entirely, so we don't want to rely on those images living in the framework when switching to the new data architecture.

To test:
Go to Stats > Period.
Verify that the flags are still displayed correctly.

[peril-wordpress-mobile]

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

[ghost]

Do we have vector or higher-resolution versions of these assets available?

[ghost]

It appears that these images are 72px square, effectively 24pts on larger devices.

[jklausa]

That's a great question!

@SylvesterWilmott do you know if we have those somewhere and if so, how could I obtain them?

[ghost]

Would it be possible to add tests to ensure that these asset catalog entries can all be loaded successfully?

[ghost]

Should this diff also be accompanied by 258 deletions, reflecting removal of the standalone PNGs from WordPressComStatsiOS?

[jklausa]

Not yet, since we're gonna ship the new stats in the next release and those are required to remain in place for the "old" Stats to continue to work.

[jklausa]

Would it be possible to add tests to ensure that these asset catalog entries can all be loaded successfully?

Great point.

[ghost]

Hi @jklausa - I left a few comments. I think this is headed in the right direction, but there are a few things that give me pause.

1. It appears that we've moved (copied) assets, essentially doubling the footprint of our image assets.
2. It appears that a "hack" method mentioned in the comments can be removed in favor of the correct solution.

At a minimum, I'd like to see that either (a) these items are addressed before we merge the PR; or (b) we create new issues that allow us to track & address them subsequently.

I also think there's an opportunity to work with design to create higher-resolution assets that will enable to put our best foot forward once our refreshed Stats feature launches, but acknowledge that that may be outside the scope of this PR.

cc: @SylvesterWilmott - do we have these image assets (i.e., country flags) available at higher resolutions?

[jklausa]

I updated this, removing the "hack" and adding tests to make sure that the images can be loaded correctly.

I think removing the "old" assets is captured by #10975 — when we remove WordPressComStatsiOS, we'll get rid of the other copy too :)

I'm happy to let this PR wait here for a while if @SylvesterWilmott can point us to a higher-resolution assets.

[SylvesterWilmott]

@stevebaranski is there a reason we need higher resolution flags? The flag icons should only ever appear at 24pt size so the 72pt icons are perfect for 3x displays.

I would actually even encourage Android to adopt the flag icons we use in iOS @planarvoid

[ghost]

is there a reason we need higher resolution flags? The flag icons should only ever appear at 24pt size so the 72pt icons are perfect for 3x displays.

@SylvesterWilmott I appreciate that the dimension specified in Zeplin is 24pt square. If we'd like to afford ourselves flexibility in the future, now is the time to make such a change. I'd rather ask now than never! 😄

I was most concerned about the manner with which they were imported into the asset catalog. For example:

Note that the base image was imported into the "1x" cell within the asset catalog. This has implications when a build is created for the App Store, and then thinned for each device, especially when we're vending raster assets.

@jklausa - based on Sylvester's input here, I think these images should be placed in the 3x cell for each asset. Agreed?

[ghost]

@jklausa once this is merged, we might want to advise our platform counterparts that we anticipate a slight uptick in the app footprint due to these extra images.

[jklausa]

@stevebaranski argh, I forgot about this PR to death. I managed to wrangle a neat vim macro that let me update all the files in one go and I added a test to make sure the images are loading in a correct size/scale.

I think we should be good to ship this now :)

[ghost]

Hi @jklausa - yes indeed, this looks good to me now!