[Stats Refresh] Insights: Loading View#11597
Merged
danielebogo merged 13 commits intodevelopfrom May 2, 2019
Merged
Conversation
- Fix image animation when the view is updated - Using ChildViewExtension to remove itself
ScoutHarris
approved these changes
May 1, 2019
Contributor
ScoutHarris
left a comment
ScoutHarris
left a comment
There was a problem hiding this comment.
Hey @danielebogo . I'm loving the NoResultsViewHost! Nice!
And the loading view does in fact appear as expected.
45 tasks
Contributor
Author
|
Thanks @ScoutHarris ! |
|
Looks good @danielebogo |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs. #10379
This PR adds a loading view for the Stats Insights section.
NoResultsViewHost
Because we often duplicate the code to add the NoResultsViewController as child, I thought to create a helper using a protocol called
NoResultsViewHost(thanks @frosty for the name suggestion). Its extension constrained to a UIViewController contains the logic to configure, display and hide the noResultsViewController object. Also using associated objects allows us to implement the protocol without any other particular implementation.Error Handling
I will push another PR for the error handling. This because it requires some change on the Store.
To test:
• From My Sites select a site and open its dashboard
• Select Stats to open the Stats section. Be sure the tab Insights is selected.
• You should see the loading view
• The loading view should disappear as soon the data is loaded
Update release notes:
RELEASE-NOTES.txt.