Skip to content

[DO NOT MERGE] [CI only] Task/prominent suggestions#19009

Merged
twstokes merged 18 commits intotrunkfrom
task/prominent-suggestions
Jul 8, 2022
Merged

[DO NOT MERGE] [CI only] Task/prominent suggestions#19009
twstokes merged 18 commits intotrunkfrom
task/prominent-suggestions

Conversation

@twstokes
Copy link
Contributor

@twstokes twstokes commented Jul 7, 2022

Do not merge - this PR is only to run CI for #18979. Thanks!

salimbraksa added 14 commits July 7, 2022 18:51
@salimbraksa
Add ID attribute to UserSuggestion entity
17ad622
@salimbraksa
Move prominent suggestions to appear at the top of suggestions list
bbd0394
@salimbraksa
Pass prominent suggestions ids to Fullscreen Comment VC
7c83210
@salimbraksa
Handle the case of nil post in reader comments screen
9359a34
@salimbraksa
Add prominent suggestions feature to comment detail screen
5896d0b
@salimbraksa
Add prominent suggestions feature to notifcation detail screen
60794fd
@salimbraksa
Handle more cases where we had to configure fullscreen comment with p…
a8a8df0 
…rominent suggestion ids
@salimbraksa
Exclude the current user from prominent suggestions
0a88731
@salimbraksa
Rewrite showSuggestionsForWord to Swift and refactor some methods to …
8727035 
…pure functions
@salimbraksa
Change SuggestionsTableView.prominentSuggestions to accept only 1 com…
fae3e65 
…mentAuthorId
@salimbraksa
Remove unnecessary whitespace
4af0295
@salimbraksa
Rename UserSuggestion.id to userID and bump core data model version t…
8b2dca6 
…o 144
@salimbraksa
Update RELEASE-NOTES
fddfff1
@salimbraksa
Refactor moveProminentSuggestionsToTop searchResults param type to [U…
0c98be8 
…serSuggestion]
@twstokes twstokes self-assigned this Jul 7, 2022
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 7, 2022 •
edited
Loading

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@twstokes twstokes mentioned this pull request Jul 7, 2022
Merged
4 tasks
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 7, 2022 •
edited
Loading

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19009-f3c8579 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jul 7, 2022 •
edited
Loading

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19009-f3c8579 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@salimbraksa @twstokes
Update RELEASE-NOTES.txt
f3c8579 
Co-authored-by: Tanner Stokes <tanner@tannr.com>
@twstokes twstokes merged commit 03fd973 into trunk Jul 8, 2022
@twstokes twstokes deleted the task/prominent-suggestions branch July 8, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@twstokes twstokes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@twstokes @wpmobilebot @salimbraksa