Replace a do-catch block with Result(catching:)

[mokagio]

This Result initializer takes a throwing closure as input and returns a Result wrapping its result.

See https://developer.apple.com/documentation/swift/result/init(catching:)

Regression Notes

1. Potential unintended areas of impact – The behavior of the method I edited is covered by unit tests. If I made a mistake, the test will tell us.
2. What I did to test those areas of impact (or what existing automated tests I relied on) – N.A.
3. What automated tests I added (or what prevented me from doing so) – N.A.

---

• I have completed the Regression Notes.
• I have considered adding unit tests for my changes. N.A.
• I have considered adding accessibility improvements for my changes. N.A.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. N.A.

[mokagio]

@crazytonyli I find this more readable (and indulgent in using Result API 🤓 ).

YMMV. Given the functionality doesn't change, I won't mind if you'd rather keep your version 👍

[crazytonyli]

Neat! I didn't know this function exists.

[wpmobilebot]

You can test the changes in Jetpack from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19259-320b58f on your iPhone

If you need access to App Center, please ask a maintainer to add you.

[wpmobilebot]

You can test the changes in WordPress from this Pull Request by:

• Clicking here or scanning the QR code below to access App Center
• Then installing the build number pr19259-320b58f on your iPhone

If you need access to App Center, please ask a maintainer to add you.