Closed
Conversation
wpmobilebot
reviewed
Nov 1, 2022
fastlane/lanes/localization.rb
Outdated
| ) | ||
|
|
||
| git_commit(path: [wordpress_en_lproj], message: 'Update strings for localization', allow_nothing_to_commit: true) | ||
| unless options[:skip_commit] |
Contributor
There was a problem hiding this comment.
| 🚫 | Favor modifier unless usage when having a single-line body. Another good alternative is the usage of control flow &&/||. |
ed7f71f to
8d0d572
Compare
Contributor
You can test the changes in WordPress from this Pull Request by:
|
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
4ea56b2 to
3009f79
Compare
4 tasks
193ad92 to
6d01c35
Compare
b31a9cb to
55723f4
Compare
55723f4 to
6c2e50b
Compare
4 tasks
6c2e50b to
f0fa648
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.