Merged
Conversation
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
This was referenced Feb 17, 2023
twstokes
approved these changes
Feb 17, 2023
Contributor
There was a problem hiding this comment.
This looks great to me @guarani, thanks for adding the tests! 🚀
I left just a couple nitty, optional comments. I also left a question on the WPKit PR.
All manual tests matched the table in the testing portion of the PR.
Thanks!
WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift
Outdated
Show resolved
Hide resolved
WordPress/Classes/ViewRelated/Support/SupportTableViewController.swift
Outdated
Show resolved
Hide resolved
Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20154
This PR updates the WP app to show Zendesk support to paying users (i.e. those with at least one site that has a paid plan) and show forum support to free users. No changes were made to the JP app.
To test
Verify the following behavior:
Note:
Regression Notes
If this change isn't properly implemented, it could prevent users of the WP and JP apps from getting support.
I tested using the above table on an iPhone.
I updated existing tests to provide test coverage for this change.
PR submission checklist:
RELEASE-NOTES.txtif necessary.