Skip to content

Show Zendesk to paying users#20163

Merged
guarani merged 5 commits intotrunkfrom
update/show-zendesk-to-paying-users
Feb 18, 2023
Merged

Show Zendesk to paying users#20163
guarani merged 5 commits intotrunkfrom
update/show-zendesk-to-paying-users

Conversation

@guarani
Copy link
Contributor

@guarani guarani commented Feb 17, 2023

Fixes #20154

This PR updates the WP app to show Zendesk support to paying users (i.e. those with at least one site that has a paid plan) and show forum support to free users. No changes were made to the JP app.

⚠️ This PR relies on the following bug fix: wordpress-mobile/WordPressKit-iOS#578

To test

Verify the following behavior:

Feature Flag Plan Support
WP App On Free Forum
WP App On Paid Zendesk
WP App Off Any Zendesk
JP App Any Any Zendesk

Note:

  • The feature flag is under Me | App Settings | Debug | "Provide support through a forum"
  • If Zendesk is not available (if the Zendesk SDK isn't ready for whatever reason) we show the forum, no matter which app it is or what plan the user is on.

Regression Notes

  1. Potential unintended areas of impact

If this change isn't properly implemented, it could prevent users of the WP and JP apps from getting support.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

I tested using the above table on an iPhone.

  1. What automated tests I added (or what prevented me from doing so)

I updated existing tests to provide test coverage for this change.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 17, 2023

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20163-bd069be on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 17, 2023

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr20163-bd069be on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@guarani guarani marked this pull request as ready for review February 17, 2023 21:26
@twstokes twstokes self-requested a review February 17, 2023 21:42
Copy link
Contributor

@twstokes twstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me @guarani, thanks for adding the tests! 🚀

I left just a couple nitty, optional comments. I also left a question on the WPKit PR.

All manual tests matched the table in the testing portion of the PR.

Thanks!

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@guarani guarani enabled auto-merge February 18, 2023 00:15
@guarani guarani merged commit ca9d74e into trunk Feb 18, 2023
@guarani guarani deleted the update/show-zendesk-to-paying-users branch February 18, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only show Zendesk support to WP.com users on paid plans

3 participants