Comments: Add the new header component#20753
Merged
Conversation
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20753-df561e2 | |
| Version | 22.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | df561e2 | |
| App Center Build | jetpack-installable-builds #5118 |
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20753-df561e2 | |
| Version | 22.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | df561e2 | |
| App Center Build | WPiOS - One-Offs #6094 |
kyleaparker
suggested changes
May 30, 2023
kyleaparker
left a comment
There was a problem hiding this comment.
Looks really good to me. The only change I think we could try is a lighter material :)
Contributor
|
Bumping this to 22.7 because I'm starting the 22.6 code freeze today and this is still a draft. |
wargcm
approved these changes
Jun 22, 2023
Contributor
wargcm
left a comment
There was a problem hiding this comment.
I checked:
✅ Light/dark mode
✅ Different accessibility sizes
✅ VoiceOver
✅ RtL language
LGTM! ![]()
WordPress/Classes/ViewRelated/Comments/CommentTableHeaderView.swift
Outdated
Show resolved
Hide resolved
kean
reviewed
Jun 22, 2023
| @State var showsDisclosureIndicator = true | ||
|
|
||
| var body: some View { | ||
| if #available(iOS 15.0, *) { |
Contributor
There was a problem hiding this comment.
You are hopefully going to be able to remove this (and VisualEffectView) soon. There is a discussion when to merge the deployment target bump.
Contributor
Author
There was a problem hiding this comment.
Thanks for the heads up, and looking forward to it! I'll create a follow-up PR to remove them once the version bump PR gets merged.
kean
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Refs #20568
This implements a new (SwiftUI!) header component for Comment screens. Currently, this is only shown in Reader comments when the feature flag is enabled. Here are some previews:
To test
Comment Moderation Updateflag is toggled on.Regression Notes
Potential unintended areas of impact
Should be none. The feature is hidden behind a feature flag.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested the changes.
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: