Skip to content

Reader: Fix viewDidDisappear crash#20844

Merged
momo-ozawa merged 2 commits intorelease/22.6from
fix/20843-reader-crash
Jun 15, 2023
Merged

Reader: Fix viewDidDisappear crash#20844
momo-ozawa merged 2 commits intorelease/22.6from
fix/20843-reader-crash

Conversation

@momo-ozawa
Copy link
Contributor

Fixes #20843

Description

  • Fixes a crash that happens when closing the Reader

How to test

  1. Switch to the Reader tab
  2. Tap on a Reader post to open the details screen
  3. Go back to the Reader feed
  4. Repeat steps 2, 3 several times
  5. ✅ Verify: the app doesn't crash

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@momo-ozawa momo-ozawa added this to the 22.6 ❄️ milestone Jun 13, 2023
@momo-ozawa momo-ozawa self-assigned this Jun 13, 2023
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 13, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20844-291a5de
Version22.6
Bundle IDorg.wordpress.alpha
Commit291a5de
App Center BuildWPiOS - One-Offs #5971
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Jun 13, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20844-291a5de
Version22.6
Bundle IDcom.jetpack.alpha
Commit291a5de
App Center Buildjetpack-installable-builds #4999
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

Copy link
Contributor

@hassaanelgarem hassaanelgarem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@momo-ozawa momo-ozawa merged commit 661b161 into release/22.6 Jun 15, 2023
@momo-ozawa momo-ozawa deleted the fix/20843-reader-crash branch June 15, 2023 11:31
@momo-ozawa
Copy link
Contributor Author

FYI @mokagio 🙇‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reader: 'Can't add self as subview' crash when closing the Reader

5 participants