Drop iOS 14 Support: Remove MenuSheetViewController#20933
Merged
Conversation
a8da11c to
b0d45eb
Compare
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20933-b0d45eb | |
| Version | 22.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b0d45eb | |
| App Center Build | WPiOS - One-Offs #6073 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr20933-b0d45eb | |
| Version | 22.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | b0d45eb | |
| App Center Build | jetpack-installable-builds #5099 |
hassaanelgarem
approved these changes
Jun 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related Issue #20860
Remove
MenuSheetViewController.swiftwhich was a fallback forUIMenuon iOS 14. It should’ve been originally removed back in iOS 14 update but wasn't because of the incorrect#available(iOS 15, *)attribute (removed in #20917).To test:
Moderation
No Moderation
Here is why the code is, in fact, unused:
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.